Closed kavimuru closed 1 year ago
Triggered auto assignment to @MitchExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are β
)splitting bill with phone account shows @expensify.sms
Root cause of the issue is that in split bill flow, when we are fetching the payee's personal details by the method getIOUConfirmationOptionsFromPayeePersonalDetail
, we have not formatted the text and alternate text which we end up showing in <MoneyRequestConfirmationList/>
> <OptionsSelector/>
We need to format the alternate text and display name fields using formatPhoneNumber()
method in LocalePhoneNumber
util
We can find other inconsistencies (if any) and fix them all at once
Commented in Slack
@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Confirmed @expensify.sms is not expected to be shown anywhere in app
Job added to Upwork: https://www.upwork.com/jobs/~0128597348b75205c2
Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External
)
If the payee is logged in using phone number, then @expensify.sms should not be displayed while splitting bill after login id.
The login information is displayed plainly from props without formatting and as it has the format <phone number>@expensify.sms
In the function getIOUConfirmationOptionsFromPayeePersonalDetail
we need to provide check for if there is phone number(sms) based login, then we need to format that phone number by removing @expensify.sms
in another variable and then put it in alternateText
.
Since we may want to have a different format in which the login detail is displayed and not like the displayName, we will write a formatter for this purpose and the end result will be something like the one attached in the image.
https://github.com/Expensify/App/blob/cd851d0fbd901c70a32220472104ffc887639f2a/src/libs/OptionsListUtils.js#L905-L921
NA
One note to the internal engineer eventually assigned - Lets double check if we're actively removing @expensify.sms from the front end or the back end across the board just to be 100% sure
Friendly reminder to review the existing proposals @0xmiroslav π
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@0xmiroslav pls review the proposals π
@MitchExpensify @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
reviewing now
Bump: @0xmiroslav
Waiting on @0xmiroslav's review of the existing proposals, Melvin
@chiragxarora is this still reproducible? I am not able to repro.
were you able to reproduce @0xmiroslav ???
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
Friendly bump @0xmiroslav
@MitchExpensify @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
Sent a friendly bump to @0xmiroslav in Slack DM for their follow up here π
@0xmiroslav !!!!!!!!!!!!
I agree with @chiragxarora's proposal. So it's consistent with alternativeText in participant options:
π π π C+ reviewed
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Agreed!
π£ @chiragxarora π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
π£ @chiragxarora π An offer has been automatically sent to your Upwork account for the Reporter role π Thanks for contributing to the Expensify app!
@stitesExpensify can you please assign me too?
π£ @situchan π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
PR https://github.com/Expensify/App/pull/24441 is ready for review @situchan
π― β‘οΈ Woah @situchan / @chiragxarora, great job pushing this forwards! β‘οΈ
The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus π
On to the next one π
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.55-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-28. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Bump on the BZ steps @situchan
Payment summary:
Reporting: @chiragxarora $250 (Upwork) C: @chiragxarora $1500 (Upwork) C+: @situchan $1500 (Upwork)
Paid!
@MitchExpensify, @stitesExpensify, @chiragxarora, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Regarding BZ checklist: This is minor inconsistent display issue specific to phone users and does not affect any app logic including split bill. No need regression test.
Great, thanks for confirming @situchan - All done here!
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result: @expensify.sms should not be shown
Actual Result:
@expensify.sms should is shown
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.41-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/050219d3-c177-41b7-b2a2-92168126c7dc
Expensify/Expensify Issue URL: Issue reported by: @chiragxarora Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688810314872429
View all open jobs on GitHub
Upwork Automation - Do Not Edit