Notification shows incorrect default avatar

Julesssss commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create or locate an account with a default avatar
Send a notification to a user (Android only)

Expected Result:

The Android notification Avatar should be the same as the sender sees

Actual Result:

The Android notification Avatar does not match the avatar the sender sees

Sender - [King]

Receiver - [Fish] Screenshot_20230724-111351~2

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native

Version Number: v1.3.44-0 Reproducible in staging?: Yes Reproducible in production?: yes Issue reported by: me Slack conversation: N/A

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a97692b40e5dae3c
Upwork Job ID: 1683422271632924672
Last Price Increase: 2023-07-24

Issue Owner

Current Issue Owner: @CortneyOfstad

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Julesssss commented 1 year ago

I think this is backend

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01a97692b40e5dae3c

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ArekChr (Internal)

CortneyOfstad commented 1 year ago

I'm heading OoO until 8/14, so reassigning BZ to keep an eye on it in the meantime 👍

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

twisterdotcom commented 1 year ago

@Julesssss is this an internal Backend change? Do we need @ArekChr assigned at all?

Julesssss commented 1 year ago

Let's keep the assignment until it has been confirmed

melvin-bot[bot] commented 1 year ago

@twisterdotcom @Julesssss @CortneyOfstad @ArekChr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Julesssss commented 1 year ago

^ ignoring. This needs internal investigation

twisterdotcom commented 1 year ago

Can it be Weekly then?

CortneyOfstad commented 1 year ago

@twisterdotcom taking this back because I'm back from OoO and you're heading off to have a 👶!! 🎉

@Julesssss any updates on this?

Julesssss commented 1 year ago

I took a look at the code today. The default avatars should be using Cloudfront URLs and I believe we need to update the default avatars in the reportAction data. This will update NewDot mobile and OldDot.

melvin-bot[bot] commented 1 year ago

@twisterdotcom @Julesssss @CortneyOfstad @ArekChr this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] commented 1 year ago

@twisterdotcom @Julesssss @CortneyOfstad @ArekChr this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

CortneyOfstad commented 1 year ago

@Julesssss any updates on this? Thanks!

CortneyOfstad commented 1 year ago

Bump @Julesssss ^^^

Julesssss commented 1 year ago

I have been OOO since the last update. Taking another look this week or next

melvin-bot[bot] commented 1 year ago

@twisterdotcom, @Julesssss, @CortneyOfstad, @ArekChr Whoops! This issue is 2 days overdue. Let's get this updated quick!

Julesssss commented 1 year ago

Nothing has changed since this comment, but I can't prioritise this yet.

CortneyOfstad commented 1 year ago

Any updates @Julesssss? TIA!

Julesssss commented 1 year ago

Unfortunately not. It's on my list again for this week, but I'll likely be busy with higher priority issues.

CortneyOfstad commented 1 year ago

No worries @Julesssss — do you think it would be better for me to reassign another engineer?

Julesssss commented 1 year ago

Feel free to ask, but I think it's unlikely anyone will be able to prioritize this over wave issues, to be honest. I do plan to work on this during offshore, I just have a lot of more important things to get through first.

CortneyOfstad commented 1 year ago

No worries and thank you for the context! We'll keep it as is for now and if something drastically changes, I can see if someone else can pick it up 👍

CortneyOfstad commented 1 year ago

Not overdue 👍

CortneyOfstad commented 11 months ago

@Julesssss any update on this? Thanks!

Julesssss commented 11 months ago

I still think any progress here is a mont out at least. I have 3/4 wave issues on my radar which are far higher priority :/

CortneyOfstad commented 11 months ago

No update 👍

CortneyOfstad commented 11 months ago

Any updates on this @Julesssss? Thanks!

Julesssss commented 11 months ago

Sorry, nope. I might be able to get to this in December, but probably not this month.

CortneyOfstad commented 9 months ago

@Julesssss any updates here? Thanks!

Julesssss commented 9 months ago

Hey Cortney, I think we should close this issue. Given the rush for completing projects before the end of the year, I am not going to have time for this. And then next year we need to prioritise the big projects :/

CortneyOfstad commented 9 months ago

No worries and sounds good — thanks @Julesssss!

Julesssss commented 9 months ago

Since migrating #social to NewDot, this might actually be important again. Reopening

CortneyOfstad commented 8 months ago

@Julesssss an updates on this? Thanks!

Julesssss commented 8 months ago

Yeah, no update as I'm working on Wave 5 and VIP-VSB issues. Keeping an eye on this one though. It'll be a good issue to pick up after my current tasks if I can get it attached to a wave.

CortneyOfstad commented 8 months ago

Sounds good @Julesssss!

Julesssss commented 6 months ago

Not quite a priority yet

CortneyOfstad commented 6 months ago

Not overdue 👍

Sorry for the delayed response — was OoO last week 👍

CortneyOfstad commented 6 months ago

@Julesssss adjusted the status to Low — if this needs to be change, just let me know 👍

Julesssss commented 6 months ago

Thanks, that sounds good to me.

Julesssss commented 5 months ago

No change in priority here

CortneyOfstad commented 5 months ago

@Julesssss any update on an ETA? Thanks!

Julesssss commented 5 months ago

Low priority, we'll likely not worry about this bug until later in the year

CortneyOfstad commented 4 months ago

Not overdue — priority on this is low ATM 👍

CortneyOfstad commented 3 months ago

Still low priority

Julesssss commented 2 months ago

Low priority

CortneyOfstad commented 2 months ago

Not overdue!

Expensify / App