[HOLD for payment 2023-08-10] App crashes when clicking 'Split bill' button for newly created account

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign-up with a new account
2. Click on 'FAB' menu
3. Click on 'Split bill' button

   Expected Result:

   App shouldn't crash

   Actual Result:

   App crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [x] Android / Chrome
• [ ] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.48-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/5237c6d0-ffc0-42d0-a7ab-f68f6dea40bb

https://github.com/Expensify/App/assets/43996225/19296699-e8cc-4660-b1aa-767d49677ab0

Expensify/Expensify Issue URL: Issue reported by: @natnael-guchima Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690828817211769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c58572b05d76428f
• Upwork Job ID: 1689034160602599424
• Last Price Increase: 2023-08-08

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Li357]

Is this a dupe of https://github.com/Expensify/App/issues/23568?

[Li357]

Hmm, seems not because this crash occurs right when the Split Bill button is clicked. Investigating

[aldo-expensify]

In case it helps... this may have the same root cause as: https://expensify.slack.com/archives/C049HHMV9SM/p1690832195690459

[situchan]

Not reproducible on main. Only staging.

[ahmedGaber93]

I think it dup of/or same root cause https://github.com/Expensify/App/issues/23420

[situchan]

Seems like dupe. Then not sure why this is deploy blocker as https://github.com/Expensify/App/pull/17964 which caused this regression was deployed to production long time ago.

[getusha]

@situchan it's reproducible on staging only. and i don't think the linked PR is the cause no?

[Li357]

Agree, it seems to be the same root cause as https://github.com/Expensify/App/issues/23420 since currency is undefined (because default props are not applied) when loading.

[Natnael-Guchima]

Shouldn't this bug be reproducible on production too if it has the same root cause as this pr https://github.com/Expensify/App/issues/23420?

[Li357]

True, I suspect there was some backend change that was merged recently that caused this intermediate case where currency had no default. I'm going to search for it.

[hannojg]

Hey, this is very likely a regression introduced by my PR! I am looking into it:

• https://github.com/Expensify/App/pull/23749

[hannojg]

After looking into this, it seems it's a combo of changes that caused this issue. This PR will fix this error as well:

• https://github.com/Expensify/App/issues/23420
• https://github.com/Expensify/App/pull/23937

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

Should be fixed now, as of https://github.com/Expensify/App/pull/24003

[Li357]

Confirmed fix on staging!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.48-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/24003

If no regressions arise, payment will be issued on 2023-08-08. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Li357] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Li357] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Li357] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Li357] Determine if we should create a regression test for this bug.
• [ ] [@Li357] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.49-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/24003

If no regressions arise, payment will be issued on 2023-08-10. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Li357] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Li357] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Li357] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Li357] Determine if we should create a regression test for this bug.
• [ ] [@Li357] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@Li357 - it appears the only payment here is to @Natnael-Guchima for reporting. Please confirm, so I can prepare for the upcoming pay period. Thanks!

[Li357]

@alexpensify Yep! That should be it.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01c58572b05d76428f

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[alexpensify]

@Natnael-Guchima - to prepare for the upcoming pay period, I've sent a request in Upwork. Please accept and I can finalize the process on August 10. Thanks!

[Natnael-Guchima]

I have accepted the offer. Thanks @alexpensify

[alexpensify]

Here is the payment summary:

• External issue reporter - @Natnael-Guchima $250
• Contributor that fixed the issue - N/A
• Contributor+ that helped on the issue and/or PR - N/A

Upwork Job: https://www.upwork.com/jobs/~01c58572b05d76428f

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: The payment has been paid in Upwork and the job has been closed there too.