search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[$1000] Request money - '1 Reply' is not shown when money request report is created in offline mode #24129

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com
  2. Click + button > Request moneybags
  3. Complete the request money process
  4. Repeat Step 2 and 3 in offline modeling

Expected Result:

After money request is created in offline mode, the IOU preview will show '1 Reply'

Actual Result:

After money request is created in offline mode, the IOU preview does not show '1 Reply'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.50.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/a665776e-db75-4dab-9f64-208927fe009b

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017562e6ccd02ef924
  • Upwork Job ID: 1691103716394532864
  • Last Price Increase: 2023-08-14
  • Automatic offers:
    • samh-nl | Contributor | 26259731
dukenv0307 commented 1 year ago

@mountiny I think so. I saw a recent BE change and now the system message like task message or modified message also not increase thread count. I think we can close this issue now.

dylanexpensify commented 1 year ago

@mountiny mind recapping where we landed here?

deetergp commented 1 year ago

These all count as system messages and shouldn't increment the thread count? If that's the case than I agree that this should be closed.

dylanexpensify commented 1 year ago

updating today!

mountiny commented 1 year ago

Yep only ADDCOMMENT should be counted so we can close this