search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[HOLD for payment 2023-08-28] [$1000] Offline mode: Crash after deleting Split Bill request #25481

Closed izarutskaya closed 1 year ago

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Log in to any account.
  2. Turn OFF the network connection to switch to OFFLINE mode.
  3. Create a Split Bill request with two other users.
  4. This will generate two sub-reports: report A and report B >> Click on report A to view its details.
  5. Hover over the report and select the Delete option >> report A will be deleted.
  6. Click on report B >> Observation: The app CRASHES.

Expected Result:

App should not crash

Actual Result:

App Crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.55-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/468c2e32-5ef0-499c-a4bb-652085a118e5

https://github.com/Expensify/App/assets/115492554/677b458c-c71e-47b5-9139-77b5d738a1e2

Expensify/Expensify Issue URL:

Issue reported by: @tranvantoan-qn

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692279822439699

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e588feb8af6feae9
  • Upwork Job ID: 1692566105949474816
  • Last Price Increase: 2023-08-18
  • Automatic offers:
    • pradeepmdk | Contributor | 26243141
    • tranvantoan-qn | Reporter | 26243145
marcaaron commented 1 year ago

No, we cannot do this. At least for now, it's the only way a subscriber can know that some data has been removed.

MitchExpensify commented 1 year ago

Paid and contracts ended https://github.com/Expensify/App/issues/25481#issuecomment-1687070257

MitchExpensify commented 1 year ago

Bump BZ steps https://github.com/Expensify/App/issues/25481#issuecomment-1687090365

roryabraham commented 1 year ago

I checked off my pieces in the BZ checklist. The main takeaway here is that the root cause was actually a bug in Onyx, and I'm working on fixing that in https://github.com/Expensify/react-native-onyx/pull/311

MitchExpensify commented 1 year ago

Thanks @roryabraham! Looks like this can be closed in that case