search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[HOLD for payment 2023-09-27] [$1000] After deleting a mobile contact from a WorkSpace, it starts showing up in contacts as @expensify.sms #26121

Closed izarutskaya closed 1 year ago

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Log in with any of your logins
  3. Create a new workspace or open an existing one
  4. Open the workspace & click on "Members"
  5. Click on 'Invite' button
  6. Search for an invalid phone number (+2523234211)
  7. Select the user > click on "Next" > click on "Invite"
  8. Select the user & click on the "Remove" button
  9. Click on 'Invite' button

Expected Result:

The previously added contact should appear as a phone number, without the @expensify.sms termination

Actual Result:

A previously added contact is displayed as a phone number with @expensify.sms at the end

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.58-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/4fc01bef-7aa5-451c-82a0-60e30e1ca24f

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014b0b1a782b2526c6
  • Upwork Job ID: 1696345977519468544
  • Last Price Increase: 2023-08-29
  • Automatic offers:
    • mollfpr | Reviewer | 26454047
    • pradeepmdk | Contributor | 26454050
melvin-bot[bot] commented 1 year ago

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

On to the next one 🚀

jliexpensify commented 1 year ago

Bump @mollfpr to complete the checklist!

mollfpr commented 1 year ago

@jliexpensify The second PR is still on QA, so the payment date will be change.

jliexpensify commented 1 year ago

@mollfpr is this the other PR? https://github.com/Expensify/App/pull/26638

mollfpr commented 1 year ago

@jliexpensify It's #27408

jliexpensify commented 1 year ago

Cool, just changed the payment date and will check back next week to see how things are going - thanks!

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.71-12 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-27. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

jliexpensify commented 1 year ago

Payment Summary:

Upworks Job

@mollfpr bump to complete the checklist, thanks!

mollfpr commented 1 year ago

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR: [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I couldn't find the offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug. [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

For WorkSpace

  1. Open https://staging.new.expensify.com/
  2. Open the workspace or create one & click on "Members"
  3. Click on the 'Invite' button
  4. Search for an invalid phone number (+2523234211)
  5. Select the user > click on "Next" > click on "Invite"
  6. Select the user & click on the "Remove" button
  7. Click on the 'Invite' button
  8. Verify the display name on the newly added user without the domain name

For Request Money

  1. Open the Request money from the fab menu
  2. go to offline
  3. Create a Request money with an invalid phone number (either manual or distance)
  4. Verify the display name on the chat page without the domain name

For Split bill

  1. Open the Split bill from the fab menu
  2. go to offline
  3. Create split money with an invalid phone number
  4. Verify the display name on the chat page without the domain name
jliexpensify commented 1 year ago

Paid and job closed!