[HOLD for payment 2023-10-16] [$500] Approved requests shouldn't have a `delete` option

[JmillsExpensify]

While we've already implemented logic preventing paid requests from being deleted, the same isn't true for approved requests, which we've just added. Accordingly, let's remove the Delete request option from the three dot overflow menu anytime a request has been approved.

Here's mock for clarity. Notice how I've removed the Delete request option.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bd5a594a7f989566
• Upwork Job ID: 1697326804261687296
• Last Price Increase: 2023-08-31
• Automatic offers:
• cubuspl42 | Reviewer | 26523887
• Pujan92 | Contributor | 26523889

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @Pujan92 got assigned: 2023-09-06 10:16:31 Z
• when the PR got merged: 2023-10-05 07:52:04 UTC
• days elapsed: 20

On to the next one 🚀

[cubuspl42]

One of the reasons it took so long is that the issue was related to Teachers Unite / corporate policies, which require extra setup to test.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.79-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/27952

If no regressions arise, payment will be issued on 2023-10-16. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment offer (Reviewer)
• @Pujan92 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[JmillsExpensify]

@cubuspl42 I think we should add a regression test so that this doesn't happen again. Do you agree and mind suggesting one?

[JmillsExpensify]

Based on the time between assignment and merge, here's the payment summary:

• Issue reporter: N/A
• Contributor: @Pujan92 $500
• Contributor+: @cubuspl42 $500 (no payment due; via agency)

cc @Julesssss

[cubuspl42]

@JmillsExpensify

@cubuspl42 I think we should add a regression test so that this doesn't happen again. Do you agree and mind suggesting one?

I don't have a strong opinion about adding the regression test. Here are the testing steps, if we decide to add one:

• Navigate to the Teachers Unite page here and select the "I am a teacher" option.
• Input the principal's information and an e-mail address you have access to, as the approval request will be sent to this address.
• Proceed to the "Teachers Unite!" workspace and divide the bill using the Actions (+) button.
• Open a separate tab and approve the request using the Principal account ID you previously logged in with.
• On the teacher's side, inspect the IOU report and confirm that the delete option is not displayed in the context menu for the approved request.
• Click on the request to view its details. Ensure that the three-dot menu is not visible in the money request header.

[JmillsExpensify]

I don't think this is specific to the TU policy, but instead to all approved requests. That said, I can make those tweaks in the regression test. Now that @Pujan92 has been paid out, I'm going to close this issue.