[HOLD for payment 2023-09-12] [$500] DEV: [distance] flow is showing on Split Bill

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. Request money from Fab and navigate to distance
2. Close the RHP
3. Open new split bill from FAB.
4. Enter amount and continue.
5. Check that distance header is opened. (1st bug)
6. Then press next the MapBox is shown. (2nd bug).

Expected Result:

Describe what you think should've happened

Split bill flow should have been continued.

Actual Result:

Describe what actually happened

Distance Request flow is shown.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/36083550/537de597-0f0e-43b3-976d-988da38050dc

Expensify/Expensify Issue URL: Issue reported by: @jeet-dhandha Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693771673626369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111d98650a9c274fc
• Upwork Job ID: 1698686027280314368
• Last Price Increase: 2023-09-04
• Automatic offers:
• situchan | Contributor | 26737252
• jeet-dhandha | Reporter | 26737254

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0111d98650a9c274fc

[melvin-bot[bot]]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Current assignees @allroundexperts and @situchan are eligible for the External assigner, not assigning anyone new.

[napster125]

I can't reproduce it.

[mountiny]

@napster125 updated steps but @situchan already found the fix, going fast to make it in the deploy

[situchan]

PR will be ready in 5 min

[b4s36t4]

Doesn't this need any external proposal? @situchan

[mountiny]

@b4s36t4 proposal was madde in c+ slack channel, due to urgency I have asked @situchan to raise the PR straight away

[b4s36t4]

Ok understood.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.63-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/26666

If no regressions arise, payment will be issued on 2023-09-12. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter @jeet-dhandha
• [ ] Contributor that fixed the issue @situchan
• [ ] Contributor+ that helped on the issue and/or PR @allroundexperts

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @situchan requires payment
• @jeet-dhandha requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@allroundexperts / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@allroundexperts / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@allroundexperts / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@allroundexperts / @situchan] Determine if we should create a regression test for this bug.
• [ ] [@allroundexperts / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

@puneetlath I'm on parental leave; re-assigning! This is waiting for payment, tomorrow!

[mountiny]

@allroundexperts could you please recap the payments on this issue? Thanks!

[puneetlath]

It looks like @situchan was the contributor and @allroundexperts the C+, is that right?

@allroundexperts friendly bump on the checklist so that we can pay!

[puneetlath]

@allroundexperts bump again on the checklist please.

[allroundexperts]

As requested by @mountiny, following is the summary:

Payment Summary

@situchan - Contributor -> $500 + $250 urgency bonus = $750 @allroundexperts - Contributor+ -> $500 + $250 urgency bonus = $750 @jeet-dhandha - Reporter -> $50

@allroundexperts eligible for Manual payments.

Please let me know if anything needs to be changed.

[allroundexperts]

Reviewer Checklist

1. https://github.com/Expensify/App/pull/25707
2. https://github.com/Expensify/App/pull/25707/files#r1329072489
3. I can't really think of any new checklist item that could have prevented this. A Slack discussion is not needed here. More rigorous testing would have fixed this.
4. A regression test would be helpful. Following are the steps.

Regression Test Steps

1. Request money from Fab and navigate to distance and then close the RHP
2. Open new split bill from FAB.
3. Enter amount and continue.

Verify that the distance header is not shown.

4. Proceed to the next step.

Verify that MapBox is not shown.

Do we 👍 or 👎 ?

[allroundexperts]

Requested payment in ND. This is good to close!

[puneetlath]

For the regression test, I asked about it here: https://expensify.slack.com/archives/C05DWUDHVK7/p1695059126120129

@situchan @jeet-dhandha it seems for some reason the offers didn't automatically go out. Can you both apply to this job: https://www.upwork.com/jobs/~0111d98650a9c274fc

[situchan]

@puneetlath can you please try this:

1. remove Awaiting Payment
2. unassign me
3. add Help Wanted
4. assign me again

[puneetlath]

I can but it'll auto-assign another C+ if I do that. Any chance you could just apply?

[situchan]

I can but it'll auto-assign another C+ if I do that.

That will not happen 😄 as @allroundexperts is already assigned as C+

[melvin-bot[bot]]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot[bot]]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @jeet-dhandha 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[puneetlath]

Ha, right you are!

[situchan]

Just QAed upwork automation process 😁

[puneetlath]

Regression test issue: https://github.com/Expensify/Expensify/issues/318409

[puneetlath]

Payment summary:

@situchan - Contributor -> $500 + $250 urgency bonus = $750 (paid via Upwork) @allroundexperts - Contributor+ -> $500 + $250 urgency bonus = $750 @jeet-dhandha - Reporter -> $50 (paid via Upwork)

Thanks everyone. Closing!

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.