Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

mWeb - IOU- User is shown options to request money to Workspace #27077

Closed izarutskaya closed 1 year ago

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap Fab
  3. Tap request money
  4. Enter amount
  5. Tap next to note "Workspace" in options
  6. Navigate to LHN
  7. Tap fab
  8. Tap Split bill
  9. Enter an amount
  10. Tap next and note contact options

Expected Result:

In split bill, workspace is not shown as option to create IOU. Similarly, in request money also, workspaces must not be shown as options to create IOU. User must not be shown options to request money to Workspace

Actual Result:

In split bill, workspace is not shown as option to create IOU. But, in request money, workspaces are displayed as options to create IOU. User is shown options to request money to Workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.66-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/288bcb51-31fd-4662-937e-ee9423a1c90b

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

neonbhai commented 1 year ago

Probably intended: https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js#L88-L90

This passes the boolean value for includeOwnedWorkspaceChats parameter for OptionsListUtils.getNewChatOptions()

If not we can add

CONST.IOU.MONEY_REQUEST_TYPE.SPLIT

to the check.

tjferriss commented 1 year ago

Yes, this is intended behavior.