Closed kavimuru closed 1 year ago
Triggered auto assignment to @zanyrenney (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)In Split bill participants confirmation page the participant styles stays selected even though we deselect it
It is a regression from https://github.com/Expensify/App/pull/26501 where we applied a new condition for deciding isSelected
here option.name === item.searchText
. For this page, both values are undefined and it makes the conditional value true.
https://github.com/Expensify/App/blob/1baf33af3ba8e603b9cdae7ae8a99cfb5ffb2e63/src/components/OptionsList/BaseOptionsList.js#L180
cc: @rezkiy37
Before comparing both values we may need to check any of the value availability so we do not end up with comparing undefined values.
(!_.isEmpty(option.name) && option.name === item.searchText)
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash
deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @arosiclair (Engineering
), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.69-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-21. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Only payment due is: @Pujan92 for reporting bonus.
Job added to Upwork: https://www.upwork.com/jobs/~011bd3267bf049749b
Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External
)
no more people needed, just added external
for upwork job
@Pujan92 invited you for reporting bonus - https://www.upwork.com/jobs/~011bd3267bf049749b
@Pujan92 invited you for reporting bonus - https://www.upwork.com/jobs/~011bd3267bf049749b
Thanks @zanyrenney , Accepted!
offer is pending @Pujan92
Sorry, just accepted.
Paid! Thanks for your work here @Pujan92
Again sorry @zanyrenney , I got paid more, it should be $50 so I refunded $200. Hope you recieved it as I am doing refund for the first time.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Participants row should gets toggled on select/deselect
Actual Result:
Participant row stays selected
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.69-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/85686e4f-914f-4c7c-8243-a5437124c7cc
https://github.com/Expensify/App/assets/43996225/df924169-5545-4c80-9d55-3f88fa3a9d61
Expensify/Expensify Issue URL: Issue reported by: @Pujan92 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694608070230219
View all open jobs on GitHub
Upwork Automation - Do Not Edit