Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

Split bill - IOU preview in 1:1 DM is blank with undefined username when bill is split offline #27467

Closed lanitochka17 closed 10 months ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com and log in with a new Expensifail account
  2. Go offline
  3. Create a split bill with users that have no chat history
  4. Return to LHN
  5. Click on the search icon
  6. Click on the newly created 1:1 DM

Expected Result:

The IOU preview shows the requested details

Actual Result:

The IOU preview is blank. The usernames above IOU preview shows undefined

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/4547b924-e4d6-4c54-8f53-c3fc932d0c84

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

francoisl commented 1 year ago

Can reproduce on staging and not production, trying to identify the issue now.

s-alves10 commented 1 year ago

I wasn't able to reproduce on staging and on dev

francoisl commented 1 year ago

This might have to do with betas as it's not reproducible on accounts that are on public domains. It also doesn't prevent from creating the IOU when the user comes back online, so I'll remove the blocker label for now and we can keep investigating later.

melvin-bot[bot] commented 1 year ago

@francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

@francoisl Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 year ago

@francoisl 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

francoisl commented 1 year ago

I just tried this again in dev environment and can no longer reproduce the issue, any chance you can confirm @lanitochka17 please?

lanitochka17 commented 1 year ago

Issue is not reproducible on Build 1.3.74-0

https://github.com/Expensify/App/assets/78819774/8ec0a0b9-d436-4785-95b0-270f65491813

melvin-bot[bot] commented 1 year ago

@francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 12 months ago

@francoisl Still overdue 6 days?! Let's take care of this!

francoisl commented 12 months ago

Still can't reproduce on 1.3.77-2, closing!

lanitochka17 commented 11 months ago

@francoisl Hello Issue is still reproduce this by using Expensify account to create split bill with gmail accounts in offline mode.

https://github.com/Expensify/App/assets/78819774/37a30dc5-a4f5-4cfc-bc2a-37c34f4a3eb0

francoisl commented 11 months ago

Still can't reproduce on v1.3.92-0 😕 I'll demote to weekly for now and try again later

francoisl commented 10 months ago

Can't reproduce, closing.