Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.35k stars 2.78k forks source link

[C+ payment required, Situ out until May] [HOLD for payment 2024-04-03] [$500] Desktop - Login - Unable to enter the 2FA code or exit the opened screen on desktop #34177

Closed lanitochka17 closed 4 months ago

lanitochka17 commented 8 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.23-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Prerequisites: User must be logged into web app as User A.

  1. Launch the Desktop app
  2. Enter an email for an existing account with 2FA (User b)
  3. Go to the email inbox and locate the magic code
  4. Copy the Magic link and modify it to staging
  5. On the web, open a new tab and navigate to the staging magic link
  6. Confirm that the user is prompted to open the desktop app
  7. Click on the "Open app" option

Expected Result:

When the desktop is launched by the magic code link, it glitches, briefly shows a skeleton and then returns to the first login screen

Actual Result:

When the desktop is launched by the magic code link, there's just a blocker screen asking to enter the magic code, with no field and no option to exit the screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f07d7998-7fff-41b6-9f79-6dc2ef507cbd

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0183573e4ff04521ad
  • Upwork Job ID: 1744794019492372480
  • Last Price Increase: 2024-03-06
  • Automatic offers:
    • situchan | Contributor | 28115507
Issue OwnerCurrent Issue Owner: @trjExpensify
mountiny commented 6 months ago

$500 to @ikevin127 and $500 to @situchan

ikevin127 commented 5 months ago

[!note] I did receive an Upwork Contributor offer for this issue on 12th of March despite this message, but I cannot accept it as it errors (see error below) - therefore I declined it and will await BZ manual offer 🙌

Screenshot 2024-04-02 at 17 38 25
trjExpensify commented 5 months ago

Sounds good! Payment summary as follows:

Offers sent.

ikevin127 commented 5 months ago

@trjExpensify Offer accepted, thank you! 🥳

trjExpensify commented 5 months ago

Paid you!

trjExpensify commented 5 months ago

Situ is out until May, so this is going to sit until then. Updated the title to make that clear.

trjExpensify commented 5 months ago

Still awaiting Situ's return.

trjExpensify commented 4 months ago

@situchan - are you back?

trjExpensify commented 4 months ago

Still waiting on Situ so I can pay this.

situchan commented 4 months ago

Sorry for late. I think job expired. Can you please send new offer?

trjExpensify commented 4 months ago

Offer sent!

trjExpensify commented 4 months ago

Situ paid, closing!