search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.79k forks source link

[HOLD #37519][$250] LHN - Group chat created via Split Bill is missing in LHN while offline #39708

Closed kbecciv closed 4 months ago

kbecciv commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.60.6 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4477130&group_by=cases:section_id&group_order=asc&group_id=229063 Issue reported by: Applause - Internal Team

Action Performed:

  1. Open app
  2. Disable internet connection
  3. Tap on FAB > Request Money
  4. Select Manual tab
  5. Write any amount and tap on continue button
  6. Select two attendees or more
  7. Complete the split bill
  8. Navigate to LHN
  9. If split does show, navigate to another chat to see if the split disappears.

Expected Result:

Created group chat should be displayed in LHN while user offline

Actual Result:

Created group chat via Split Bill is missing in LHN when user offline. When user returned online, the group chat will appear in LHN.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/bc6126b6-57ab-4b82-ac31-b174c6c2752d

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017c274d12ce7633c6
  • Upwork Job ID: 1776410861693710336
  • Last Price Increase: 2024-04-06
melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

kbecciv commented 5 months ago

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~017c274d12ce7633c6

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

mallenexpensify commented 5 months ago

Added to the OP cuz my repro was a lil different

  1. If split does show, navigate to another chat to see if the split disappears.

@mananjadhav , let me know if you don't think this can be external.

nkdengineer commented 5 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Created group chat via Split Bill is missing in LHN when user offline. When user returned online, the group chat will appear in LHN.

What is the root cause of that problem?

In here, we're incorrectly setting the notificationPreference of the optimistically created group chat to HIDDEN, which makes it hide from the LHN. This is also inconsistent with the back-end which will return notificationPreference as always for the group chat when coming online.

What changes do you think we should make in order to solve the problem?

In here, do not set the notificationPreference of the optimistically created group chat to HIDDEN, so it will fallback to always here which is the correct value.

What alternative solutions did you explore? (Optional)

NA

mananjadhav commented 5 months ago

Thanks for updating the OP. I think this can be external because it's all offline but I'll check this on Monday.

melvin-bot[bot] commented 5 months ago

@mananjadhav, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mallenexpensify commented 5 months ago

@mananjadhav , please review the proposal above.

mananjadhav commented 5 months ago

@nkdengineer Your proposal didn't work for me. ~I am not sure how notification preference have an impact on the LHN.~ Rechecked this.

Still reviewing.

mananjadhav commented 5 months ago

@mallenexpensify I think we should we should this one for https://github.com/Expensify/App/issues/37519. I think fixing the linked issue should resolved this.

mallenexpensify commented 5 months ago

Thanks @mananjadhav , done. Removed Help Wanted and bumped to weekly.

mallenexpensify commented 5 months ago

PR for what we're held on is moving along

mananjadhav commented 4 months ago

I think we're good to close this one. The linked PR fixes this and has been deployed to production.

mananjadhav commented 4 months ago

Quick bump @mallenexpensify

mallenexpensify commented 4 months ago

Thanks @mananjadhav , I'm able to confirm the group chat shows in LHN on Web-Chrome-Staging

image