Sign in – Unable to login via Magic link, Magic code expired appears

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.27-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4906568 Email or phone of affected tester (no customers): applausetester+jp_330824@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. In Sign in page enter new Expensify email
3. Open email and copy Magic link
4. Change it to staging and navigate to it in a new tab

Expected Result:

Abracadabra page opens. We have KI https://github.com/Expensify/App/issues/44600

Actual Result:

Magic code expired appears

Workaround:

Unknown

Platforms:

• [ ] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/95bd518d-9518-4026-93a7-72a999342cea

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ishpaul777]

Can't reproduce, tried multiple times

https://github.com/user-attachments/assets/89c82774-0c55-4004-8db4-32d54199f9e7

[danieldoglas]

@IuliiaHerets can you try this one again? Looks like you were logged in on a tab already on your video, so maybe that's why?

[danieldoglas]

not a deploy blocker for the API since it doesn't happen in production

[IuliiaHerets]

@danieldoglas Issue is still reproducible, build - v9.0.27-0

https://github.com/user-attachments/assets/257f319c-757c-4f47-86e3-5ca4c612d231

[ishpaul777]

We are awaiting proposals

[danieldoglas]

@ishpaul777 are you able to reproduce this now?

[ishpaul777]

Lol no, my instinct kicked in and i wrote "awaiting proposal", what i mean is waiting reliable steps to repro

https://github.com/user-attachments/assets/ba5d5188-4358-4c4a-a71a-abd4150b0c43

[deetergp]

I just ran into this on staging by sending an Invoice from one user to an email address that does not yet have an Expensify account. I was able to reproduce a second time by sending to another email without an account.

[danieldoglas]

nice, thanks for that @deetergp . @ishpaul777 can you try those steps and confirm it still fails? Then we can open it for external proposals.

[ishpaul777]

Seems we have a existing issue that we can not send a invoice to any user.

https://expensify.slack.com/archives/C01GTK53T8Q/p1725613866403789

[melvin-bot[bot]]

@danieldoglas @muttmuure @ishpaul777 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ishpaul777]

still not able to reproduce the issue, i see theres draft PR that may fix this issue https://github.com/Expensify/App/pull/48899

[ishpaul777]

Same as ^

[danieldoglas]

K, I'll close this issue for now.

[IuliiaHerets]

@danieldoglas QA team still can repro the issue, build - v9.0.46-2

https://github.com/user-attachments/assets/c14af83f-ad55-4fa9-8c2b-73de3b29cee7

[danieldoglas]

can you try to not delete the https:// part of the URL? I think the issue is that there's a redirect happening from HTTP > https and the router is somehow not figuring out the whole path string.

It works normally for me in the same scenario:

https://github.com/user-attachments/assets/a0b08175-f9a6-49ee-b6a5-e18a6e1f090b

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @danieldoglas, @muttmuure, @ishpaul777 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[ishpaul777]

@IuliiaHerets please help retest, i can't reproduce

[IuliiaHerets]

@ishpaul777 Tester can't reproduce this issue in the latest build (v9.0.60-0)

https://github.com/user-attachments/assets/70ac4da6-803f-4728-9dfa-eec81d5b0685

[ishpaul777]

@muttmuure/ @danieldoglas Should we close this ?

[danieldoglas]

Yep, closing!

[IuliiaHerets]

QA team can reproduce this issue in the latest build (9.0.64-0), issue still repro using this comment too

https://github.com/user-attachments/assets/a75074a2-3621-4c65-b3b0-6366b7e26501

[ishpaul777]

🤦 i'll advertise this on slack

[CyberAndrii]

BE issue. SigninUserWithLink returns the following error for unverified accounts. Verified accounts work without issues.

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "58c55da5-23a5-4926-84d8-7c0319e16e91",
    "message": "Invalid request. Please try signing again with link from the email",
    "title": "",
    "data": [],
    "htmlMessage": "",
    "requestID": "8e523d3feef83542-WAW"
}