Web - IOU - Console error when paying elsewhere as invited user

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.31-16 Reproducible in staging?: Y Reproducible in production?: N Issue was found when executing this PR: https://github.com/Expensify/App/pull/45264 Issue reported by: Applause internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in as user A
2. Submit an expense to user B who does not have an expensify account yet
3. Navigate to the email box and copy the link inviting user B to pay the expense
4. Open incognito and paste the link inviting user B to pay the expense
5. Select "Pay elsewhere" on the IOU preview or select Pay with expensify > Business and then "Pay elsewhere"

Expected Result:

There should be no console errors

Actual Result:

There is a console error after clicking "Pay elsewhere"

Workaround:

Unknown

Platforms:

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

1009_2.txt

https://github.com/user-attachments/assets/f797b4a4-71fb-4983-88ba-a17ea2d68012

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @deetergp

[melvin-bot[bot]]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[IuliiaHerets]

Prod

[cdOut]

I worked on the linked issue, I'll look for a fix to this one.

[MonilBhavsar]

Thank you! Would appreciate it

[cdOut]

Just after a glance this looks suspicious as I'm not modifying the value for NVP_ONBOARDING on the frontend side, I'll investigate further.

[cdOut]

Alright I've found the culprit, the problem is as follows:

• Old accounts handled the NVP_ONBOARDING value as an array, and so we have that set as a secondary type for this ONYXKEY - these old values are currently just read, there is no way in the app to change them
• New accounts receive an object with the required property that always has a value of hasCompletedGuidedSetupFlow and an optional chatReportID
• This is where the problem arises, as for the new case when we create an account while navigating through the email link, the nvp value is set to an empty array, which we then want to update to an object after pressing the Pay elsewhere button and Onyx doesn't like us shuffling the types here

I'll talk with @deetergp whether we can patch this on the backend side as it seems most fitting to just create new accounts with the value for NVP_ONBOARDING set to {hasCompletedGuidedSetupFlow: false}

[luacmartins]

This is a backend issue. Not a blocker though

[deetergp]

@cdOut Where is it in the Pay Elsewhere flow that we are setting NVP_ONBOARDING?

[cdOut]

@deetergp This isn't being done on frontend, what is happening is we're getting an OnyxUpdate that sets it from the backend through completeGuidedSetup.

[deetergp]

I just raised a PR to skip creating that NVP for invited users and setting it to true on the back end.

[cdOut]

I just raised a PR to skip creating that NVP for invited users and setting it to true on the back end.

Will that also be the case for users invited to groups / workspaces?

[deetergp]

Will that also be the case for users invited to groups / workspaces?

I haven't tested it yet, but it should.

[RachCHopkins]

@deetergp automation is borked - do I need to pay anyone here?

[deetergp]

@RachCHopkins I don't think so, Tymo is from SoftwareMansion.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.