search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.35k stars 2.78k forks source link

[$250] Android & iOS - Spend category - Unable to select category when keyboard is up #48928

Open IuliiaHerets opened 2 weeks ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.31-12 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app.
  2. Go to workspace chat.
  3. Start a manual expense flow.
  4. On confirmation page, tap Category.
  5. With keyboard up, tap on any category.
  6. Note that the category can be selected when keyboard is up.
  7. Go to workspace settings > Categories.
  8. Click Settings.
  9. Click on any spend.
  10. With keyboard up, tap on any category.

Expected Result:

User should be able to select any category when keyboard is up (also this is mweb behavior).

Actual Result:

The keyboard is dismissed and the category is not selected when keyboard is up.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/f309c758-fff2-4fb0-80b8-d6a1a83ba2b3

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836880412171065631
  • Upwork Job ID: 1836880412171065631
  • Last Price Increase: 2024-09-26
Issue OwnerCurrent Issue Owner: @rayane-djouah
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 weeks ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 2 weeks ago

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

dominictb commented 2 weeks ago

Edited by proposal-police: This proposal was edited at 2024-09-11 06:25:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

https://github.com/Expensify/App/blob/762bffcfad4ca7c4553eabedde5a2ba47871bdb5/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx#L103

so the keyboardShouldPersistTaps="always" does not work anymore. The same issue is reported here.

What changes do you think we should make in order to solve the problem?

mallenexpensify commented 2 weeks ago

OOO til Tues, will revisit/review once back. If anyone thinks this can't wait til then, post in #expensify-open-source to get 👀 and another BZ assigned.

MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

mallenexpensify commented 1 week ago

Not reproducible on iOS, Safari, production.

@dominictb , if you're able to repro, can you please provide details? Thx

https://github.com/user-attachments/assets/836adb4e-2d0a-4c86-83e4-3151c22e5a78

dominictb commented 1 week ago

@mallenexpensify I can reproduce it in latest main on IOS Native:

  1. Go to workspace settings > Categories.
  2. Click Settings.
  3. Click on any spend.
  4. With keyboard up, tap on any category.
  5. The keyboard is dismissed and the category is not selected when keyboard is up.

https://github.com/user-attachments/assets/c17827e2-db12-4832-87b6-d6004edc8ffe

mallenexpensify commented 1 week ago

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

https://github.com/user-attachments/assets/02456fc6-5e79-4f66-bc96-5facaaede608

dominictb commented 1 week ago

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

I can't reproduce this issue on staging/production because my account doesn't have access to that feature. I need to use the dev version to mock and access all the beta features.

dominictb commented 1 week ago

@mallenexpensify Please note, the "step 4. With keyboard up, tap on any category." in my reproduce steps is very important.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021836880412171065631

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

mallenexpensify commented 1 week ago

I'm guessing this can likely be External then. @rayane-djouah , can you attempt reproduction? Thx

rayane-djouah commented 4 days ago

Will review this in my morning 👍

rayane-djouah commented 4 days ago

@mallenexpensify I can't reproduce this. The bug has been fixed in https://github.com/Expensify/App/pull/49030

mallenexpensify commented 3 days ago

gonna throw retest-weekly on here, assuming QA can't reproduce, I'll close.

melvin-bot[bot] commented 3 days ago

@mallenexpensify @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

dominictb commented 1 day ago

I cannot reproduce the issue in WorkspaceCategoriesSettingsPage page now since it was fixed by this refactor.

But with the same root cause, we can reproduce that issue in other pages, such as PolicyDistanceRatesSettingsPage:

https://github.com/user-attachments/assets/0313aba0-8a89-4816-a0e5-dc6bf96679e8

Do you want to fix that? @mallenexpensify?

melvin-bot[bot] commented 1 day ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 hour ago

@mallenexpensify, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

rayane-djouah commented 46 minutes ago

@mallenexpensify I can reproduce the bug on another page, as @dominictb mentioned above.

Steps:

  1. Go to Settings > Workspaces > More Features > Enable Distance Rate
  2. Navigate to Workspace Settings > Default Category
  3. With keyboard up, tap on any category

Expected Result: Users should be able to select any category when the keyboard is up (also this is mweb behavior).

Actual Result: The keyboard is dismissed and the category is not selected when the keyboard is up.

Version: v9.0.40-6

Platforms: Android and iOS native apps

https://github.com/user-attachments/assets/16bd8602-0583-4eae-9610-a368ecff4cb4

Do you think we should address this issue?