[$250] Android & iOS - Spend category - Unable to select category when keyboard is up

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.31-12 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to workspace chat.
Start a manual expense flow.
On confirmation page, tap Category.
With keyboard up, tap on any category.
Note that the category can be selected when keyboard is up.
Go to workspace settings > Categories.
Click Settings.
Click on any spend.
With keyboard up, tap on any category.

Expected Result:

User should be able to select any category when keyboard is up (also this is mweb behavior).

Actual Result:

The keyboard is dismissed and the category is not selected when keyboard is up.

Workaround:

Unknown

Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/f309c758-fff2-4fb0-80b8-d6a1a83ba2b3

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836880412171065631
Upwork Job ID: 1836880412171065631
Last Price Increase: 2024-10-08
Automatic offers:

rayane-djouah | Reviewer | 104357393
dominictb | Contributor | 104357395

Issue Owner

Current Issue Owner: @robertjchen

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 month ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 1 month ago

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

dominictb commented 1 month ago

Edited by proposal-police: This proposal was edited at 2024-09-11 06:25:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The keyboard is dismissed and the category is not selected when keyboard is up.

What is the root cause of that problem?

An issue has been reported here, which highlights that using a ScrollView inside another ScrollView breaks the keyboardShouldPersistTaps="always" functionality.
In our app, specifically in the PolicyDistanceRatesSettingsPage, we have a similar setup. The ScrollView used in CategoryPicker: https://github.com/Expensify/App/blob/46f3d2c00ae50be2307c068af533701915c3aab3/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L124 is nested inside another ScrollView: https://github.com/Expensify/App/blob/46f3d2c00ae50be2307c068af533701915c3aab3/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L100
This is also how we can find a similar bug in our app.

What changes do you think we should make in order to solve the problem?
We can update: https://github.com/Expensify/App/blob/46f3d2c00ae50be2307c068af533701915c3aab3/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L100 to:
```
                        <ScrollView contentContainerStyle={styles.flexGrow1} keyboardShouldPersistTaps="always">
```

What alternative solutions did you explore? (Optional)

mallenexpensify commented 1 month ago

OOO til Tues, will revisit/review once back. If anyone thinks this can't wait til then, post in #expensify-open-source to get 👀 and another BZ assigned.

MelvinBot commented 3 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

mallenexpensify commented 3 weeks ago

Not reproducible on iOS, Safari, production.

@dominictb , if you're able to repro, can you please provide details? Thx

https://github.com/user-attachments/assets/836adb4e-2d0a-4c86-83e4-3151c22e5a78

dominictb commented 3 weeks ago

@mallenexpensify I can reproduce it in latest main on IOS Native:

Go to workspace settings > Categories.
Click Settings.
Click on any spend.
With keyboard up, tap on any category.
The keyboard is dismissed and the category is not selected when keyboard is up.

https://github.com/user-attachments/assets/c17827e2-db12-4832-87b6-d6004edc8ffe

mallenexpensify commented 3 weeks ago

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

https://github.com/user-attachments/assets/02456fc6-5e79-4f66-bc96-5facaaede608

dominictb commented 3 weeks ago

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

I can't reproduce this issue on staging/production because my account doesn't have access to that feature. I need to use the dev version to mock and access all the beta features.

dominictb commented 3 weeks ago

@mallenexpensify Please note, the "step 4. With keyboard up, tap on any category." in my reproduce steps is very important.

melvin-bot[bot] commented 3 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021836880412171065631

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

mallenexpensify commented 3 weeks ago

I'm guessing this can likely be External then. @rayane-djouah , can you attempt reproduction? Thx

rayane-djouah commented 3 weeks ago

Will review this in my morning 👍

rayane-djouah commented 2 weeks ago

@mallenexpensify I can't reproduce this. The bug has been fixed in https://github.com/Expensify/App/pull/49030

mallenexpensify commented 2 weeks ago

gonna throw retest-weekly on here, assuming QA can't reproduce, I'll close.

melvin-bot[bot] commented 2 weeks ago

@mallenexpensify @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

dominictb commented 2 weeks ago

I cannot reproduce the issue in WorkspaceCategoriesSettingsPage page now since it was fixed by this refactor.

But with the same root cause, we can reproduce that issue in other pages, such as PolicyDistanceRatesSettingsPage:

https://github.com/user-attachments/assets/0313aba0-8a89-4816-a0e5-dc6bf96679e8

Do you want to fix that? @mallenexpensify?

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 2 weeks ago

@mallenexpensify, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

rayane-djouah commented 2 weeks ago

@mallenexpensify I can reproduce the bug on another page, as @dominictb mentioned above.

Steps:

Go to Settings > Workspaces > More Features > Enable Distance Rate
Navigate to Workspace Settings > Default Category
With keyboard up, tap on any category

Expected Result: Users should be able to select any category when the keyboard is up (also this is mweb behavior).

Actual Result: The keyboard is dismissed and the category is not selected when the keyboard is up.

Version: v9.0.40-6

Platforms: Android and iOS native apps

https://github.com/user-attachments/assets/16bd8602-0583-4eae-9610-a368ecff4cb4

Do you think we should address this issue?

mallenexpensify commented 2 weeks ago

Do you think we should address this issue?

Ideallllllly, we'd be able to fix all instances at once. But, that's assuming we know how to easily find where the bug occurs. Do you envision the fix being the same for both?

dominictb commented 2 weeks ago

Ideallllllly, we'd be able to fix all instances at once. But, that's assuming we know how to easily find where the bug occurs

The goal of this issue is to fix all pages with a category picker that, when the keyboard is up, prevents category selection. Based on the RCA, I was able to reproduce the bug on the WorkspaceCategoriesSettingsPage (although it has been fixed by this refactor) and the PolicyDistanceRatesSettingsPage.

Do you envision the fix being the same for both?

I applied the same approach to both the WorkspaceCategoriesSettingsPage (before the refactor) and the PolicyDistanceRatesSettingsPage, and the bug was resolved in both cases.

rayane-djouah commented 1 week ago

@dominictb Could you please update your proposal with the root cause analysis and solution for the bug on the PolicyDistanceRatesSettingsPage, including how to identify the root cause to address it in all potential instances where it may occur?

mallenexpensify commented 1 week ago

Adding to #wave-collect since the bug has to do with submitting an expense

rayane-djouah commented 1 week ago

@dominictb kind reminder on https://github.com/Expensify/App/issues/48928#issuecomment-2386580931

dominictb commented 1 week ago

@rayane-djouah Sorry for my delay, I updated my proposal.

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

rayane-djouah commented 6 days ago

@dominictb's proposal looks good to me

:ribbon::eyes::ribbon: C+ reviewed

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 5 days ago

@robertjchen @mallenexpensify @rayane-djouah this issue is now 4 weeks old, please consider:

Finding a contributor to fix the bug
Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] commented 5 days ago

Upwork job price has been updated to $125

melvin-bot[bot] commented 5 days ago

Upwork job price has been updated to $250

mallenexpensify commented 5 days ago

^ was testing automation to ensure price changes were showing in Upwork jobs and... they are!

dominictb commented 4 days ago

@robertjchen Can you review the proposal here?

robertjchen commented 3 days ago

Yes, apologies for the delay! Let's move forward with @dominictb's proposal https://github.com/Expensify/App/issues/48928#issuecomment-2342727488

melvin-bot[bot] commented 3 days ago

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 3 days ago

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

Expensify / App