search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.41k stars 2.8k forks source link

Chat - Typing :finger_heart does not show up any emoji #48934

Closed IuliiaHerets closed 3 weeks ago

IuliiaHerets commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.31-12 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/48748 Email or phone of affected tester (no customers): gatantm+96@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to any chat
  2. Type :finger_heart

Expected Result:

The 🫰 emoji shows up

Actual Result:

No emoji shows up when typing :finger_heart

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/c2f6b947-6343-41c8-bbdd-77af785489ea

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 3 weeks ago

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Nodebrute commented 3 weeks ago

Edited by proposal-police: This proposal was edited at 2024-09-10 20:17:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Typing :finger_heart does not show up any emoji

What is the root cause of that problem?

We are not adding finger_heart here https://github.com/Expensify/App/blob/bfe3b75fd427ed09a40fb7bc3e80b448a4ed7a41/assets/emojis/en.ts#L546

What changes do you think we should make in order to solve the problem?

We should add finger_heart here in keywords https://github.com/Expensify/App/blob/bfe3b75fd427ed09a40fb7bc3e80b448a4ed7a41/assets/emojis/en.ts#L546 Optional: We can also add Spanish translation and we can also add any other words we want to use for this emoji

What alternative solutions did you explore? (Optional)

We can change the name here to finger_heart https://github.com/Expensify/App/blob/5d9e88ca8162b40fedeb358d6193db8b617af176/assets/emojis/common.ts#L843

greg-schroeder commented 3 weeks ago

Closing this after discussion with the team, as it's not a priority