Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.47k stars 2.82k forks source link

[No QA] Create a manual workflow for PRs deployment comments #48938

Closed rayane-djouah closed 3 weeks ago

rayane-djouah commented 1 month ago

cc @roryabraham @luacmartins

Discussing here: https://expensify.slack.com/archives/C01GTK53T8Q/p1726004633120889?thread_ts=1725898121.666369&cid=C01GTK53T8Q

Details

This PR adds a new manual workflow to comment on PRs that were deployed but the postGithubComment job of the deploy workflow failed. Example: https://github.com/Expensify/App/actions/runs/10776607506

Fixed Issues

$ PROPOSAL:

Tests

Merge the PR and run the Manual PRs Deployment Notifier manual workflow against this production deploy checklist release version: https://github.com/Expensify/App/issues/48664

Docs:

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow

Inputs:

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 1 month ago

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham commented 3 weeks ago

I suggest we close this in favor of https://github.com/Expensify/App/pull/49563. It's overall pretty similar but doesn't add a workflow only for use in manual cases when something is broken. Instead it creates a callable workflow, uses it in the main deploy.yml workflow, and exposes it such that it can be called manually if needed as well

Thanks @rayane-djouah for the idea 💡