search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.41k stars 2.8k forks source link

[$250] [Search v2.2] Chat search shows messages in rooms that you have viewed, but not joined #48947

Closed m-natarajan closed 2 weeks ago

m-natarajan commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.31-20 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726001109540449

Action Performed:

  1. With account A create a workspace-visibility room (e.g. #test-room)
  2. With account B, that is also a workspace member, view the room but don't join it
  3. With account B, navigate somewhere else in the app
  4. With account A post in #test-room
  5. With account B, go to the chats/unreads page in Search

Expected Result:

No unread message displayed in LHN

Actual Result:

The unread message displayed there, even though you aren't a member of the room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/02aa31f9-461d-4805-9fb1-761c8233812e

Snip - New Expensify - Google Chrome

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833656418639037038
  • Upwork Job ID: 1833656418639037038
  • Last Price Increase: 2024-09-10
Issue OwnerCurrent Issue Owner: @luacmartins
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

trjExpensify commented 3 weeks ago

Yep, can repro:

image
melvin-bot[bot] commented 3 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021833656418639037038

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

trjExpensify commented 3 weeks ago

CC: @luacmartins for vis!

luacmartins commented 3 weeks ago

This is backend work.

trjExpensify commented 3 weeks ago

Ah cool, thanks!

luacmartins commented 2 weeks ago

PR in review

luacmartins commented 2 weeks ago

This is done. All internal work, so we're good to close