Open IuliiaHerets opened 1 week ago
Triggered auto assignment to @anmurali (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Expense-Thread message for hold expense not shown in offline
In putOnHold here
https://github.com/Expensify/App/blob/00bc167940607f1418109f00e2b4e2d7d4ae858b/src/libs/actions/IOU.ts#L7841-L7844
we are only creating the report actions optimistically but not updating the parentReportAction with the necessary data such as childVisibleActionCount
...
Same problem exists in Unhold too.
In putOnHold
we should optimistically update parentReportAction. We can use ReportUtils.getOptimisticDataForParentReportAction
to get optimistic data with the necessary props for the parent action and set it to the optimistic data
const parentReportActionOptimistic = ReportUtils.getOptimisticDataForParentReportAction(reportID, createdReportActionComment.created, CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD);
we can also revert the changes on failureData. Same should also be done unHoldRequest
const parentReportActionOptimistic = ReportUtils.getOptimisticDataForParentReportAction(reportID, createdReportActionComment.created, CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD);
One related problem I saw here is we are not updating the lastVisibleActionCreated of the report so the app doesn't auto- scroll to the newly created hold report actions so we can set lastVisibleActionCreated
of the report optimistically for both hold (createdReportActionComment.created
) and unhold (createdReportActionComment.created
) cases.
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!
@anmurali Still overdue 6 days?! Let's take care of this!
Job added to Upwork: https://www.upwork.com/jobs/~021838745172566353951
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External
)
@FitseTLT, I generally agree with your proposal. I think the hold action is similar to sending a message, and we should try to update the parent report if it exists. However, interestingly, I'm not very sure if we should revert it back in the failureData
, since I didnβt see this reversion in the send message function either. π
https://github.com/Expensify/App/blob/48e9c176b3111870ebe5e6193312334e32c249ea/src/libs/actions/Report.ts#L605-L606
@FitseTLT, I generally agree with your proposal. I think the hold action is similar to sending a message, and we should try to update the parent report if it exists. However, interestingly, I'm not very sure if we should revert it back in the
failureData
, since I didnβt see this reversion in the send message function either. π
Agree π
OK, I think it' fine to move forward with your proposal. :)
π π π C+ reviewed
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @FitseTLT π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.36-1 Reproducible in staging?: Y Reproducible in production?: Y Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Thread message for hold expense must be shown in offline.
Actual Result:
Thread message for hold expense not shown in offline.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/7b32e081-9998-4c75-95cd-c2c29db3af96
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ntdiary