[HOLD for payment 2024-10-16] [$250] Desktop - Bank account - Modal appears to open the page in the app when I was redirected from the app

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.39-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4992364&group_by=cases:section_id&group_order=asc&group_id=283225 Issue reported by: Applause Internal Team

Action Performed:

1. Open the app
2. Log in with a new Expensifail account
3. Create a workspace
4. Navigate to Workspace settings - More features
5. Enable "Workflows"
6. Navigate to Workflows - Connect bank account
7. Click on the note to open the process in a browser

Expected Result:

The modal shouldn't appear.

Actual Result:

Modal appears to open the page in the app when I was redirected from the app.

Workaround:

Unknown

Platforms:

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/707d4d85-bdc0-496b-b30d-e21fad6e5c72

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841531184818757029
• Upwork Job ID: 1841531184818757029
• Last Price Increase: 2024-10-02

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The prompt to open on the desktop shows after redirected from the desktop app.

What is the root cause of that problem?

When we redirected from the desktop to the web app, the logic to prompt the user to open on the desktop will be executed. There is currently no logic to prevent it from showing if the user comes from the desktop app. https://github.com/Expensify/App/blob/4c768583e0df33b5f087a5b7f91d471a6b1b7bac/src/components/DeeplinkWrapper/index.website.tsx#L19-L32

What changes do you think we should make in order to solve the problem?

1. To know if the user is coming from the desktop, we can add a new param to the URL called referrer with a value of desktop. https://github.com/Expensify/App/blob/4c768583e0df33b5f087a5b7f91d471a6b1b7bac/src/libs/actions/Link.ts#L193-L202

const referrer = 'referrer=desktop';
const paramsArray = [accountID, emailParam, authTokenParam, exitTo, referrer];

buildURLWithAuthToken is currently only being used for redirecting the user from desktop to web, so we can always set the value to desktop for now.

2. Don't prompt the user if the URL params referrer is desktop. https://github.com/Expensify/App/blob/4c768583e0df33b5f087a5b7f91d471a6b1b7bac/src/components/DeeplinkWrapper/index.website.tsx#L24-L26

if (Str.startsWith(window.location.pathname, Str.normalizeUrl(ROUTES.TRANSITION_BETWEEN_APPS))) {
    const params = new URLSearchParams(window.location.search);
    if (params.get('referrer') === 'desktop') {
        return;
    }
    App.beginDeepLinkRedirectAfterTransition();
} else ...

[melvin-bot[bot]]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021841531184818757029

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[JmillsExpensify]

Not sure about the underlying issue though we have a proposal on this issue so let's get some thoughts on it.

[aimane-chnaif]

@bernhardoj's proposal looks good to me.

buildURLWithAuthToken is currently only being used for redirecting the user from desktop to web, so we can always set the value to desktop for now.

This makes sense

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

PR is ready

cc: @aimane-chnaif

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.46-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/50134

If no regressions arise, payment will be issued on 2024-10-16. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. https://expensify.testrail.io/index.php?/tests/view/4992364&group_by=cases:section_id&group_order=asc&group_id=283225

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Contributor: @bernhardoj owed $250 via NewDot
• Reviewer: @aimane-chnaif paid $250 via Upwork

BugZero Checklist (@JmillsExpensify)

• [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1841531184818757029/hired)
• [x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [x] I have verified the payment summary above is correct

[JmillsExpensify]

Payment summary is accurate.

[bernhardoj]

Requested in ND.

[trjExpensify]

Confirming the payment summary above is correct.

[JmillsExpensify]

$250 approved for @bernhardoj

[JmillsExpensify]

@aimane-chnaif I'm not seeing a record of you being paid out in Upwork. Are you seeing the same on your end? If not, I'll create a fresh offer.

[aimane-chnaif]

@JmillsExpensify I am still using upwork

[JmillsExpensify]

Offer sent

[melvin-bot[bot]]

@JmillsExpensify, @bernhardoj, @aldo-expensify, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

All contributors paid out.

[melvin-bot[bot]]

@JmillsExpensify @aldo-expensify Be sure to fill out the Contact List!