search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.35k stars 2.78k forks source link

Workspace - Nothing happens after pressing ESC key on workspace editor #49869

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh2591@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Workspaces.
  3. Click on any workspace.
  4. Press ESC key.

Expected Result:

App will return to Workspaces list.

Actual Result:

Nothing happens after pressing ESC key on workspace editor.

Workaround:

Unknown

Platforms:

Screenshots/Videos

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 2 hours ago

We think that this bug might be related to #wave-collect - Release 1

bondydaa commented 2 hours ago

I don't think this needs to be a blocker and I'm not actually sure if that is a useful UX pattern to have.

bondydaa commented 1 hour ago

started a discussion here (internal slack) https://expensify.slack.com/archives/C03U7DCU4/p1727472828047069