search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

[Needs copy update] Web - Sage - "Can't connect to integration. ("")" error after adding user-defined dimension #50235

Open IuliiaHerets opened 1 month ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.44-8 Reproducible in staging?: Y Reproducible in production?: Y Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new Gmail account
  3. Click on FAB - New workspace
  4. Enable "Accounting" in the "More features" page.
  5. Navigate to "Accounting"
  6. Connect to Sage Intacct and upgrade the workspace to Control when asked
  7. Wait for the sync to finish
  8. Navigate to Import - User-defined dimensions
  9. Click on the "Add user-defined dimension"
  10. Input any name and select any option for "Displayed as"
  11. Click on the "Confirm" button
  12. Dismiss the RHP
  13. Wait for the sync to finish

Expected Result:

The error shouldn't be visible or should be more informative that the issue is connected to user-defined dimensions.

Actual Result:

"Can't connect to integration. ("")" error appears after adding user-defined dimension. It disappears if the user-defined dimension is removed.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/4c11beba-3739-490d-96a6-1a2301984d54

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 month ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 1 month ago

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

allgandalf commented 1 month ago

Most Probably a BE bug,

strepanier03 commented 1 month ago

I'll see what I can find. I'm thinking I'll have to get logs and check in Sage to ensure the UDD is set up correctly.

melvin-bot[bot] commented 1 month ago

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 month ago

@strepanier03 Eep! 4 days overdue now. Issues have feelings too...

strepanier03 commented 1 month ago

Haven't been able to dig into this more yet, hoping to prioritize tomorrow.

melvin-bot[bot] commented 1 month ago

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 1 month ago

Still investigating.

melvin-bot[bot] commented 1 month ago

@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 month ago

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 month ago

@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

strepanier03 commented 1 month ago

Got around to testing this and was confused until I realized the issue here isn't an actual issue with the connection and user-defined dimensions, it's just clarifying the error message copy.

I will figure out what we do for Classic so I can suggest copy as well as get input on copy.

strepanier03 commented 1 month ago

Suggestion

What: Create a new ExpensiError for New Expensify Sage Intacct connection.

Suggestion: ExpensiError #?#: Invalid User-defined dimension integration name.

How do you produce the error?

  1. Click Settings > Workspaces > workspace name > Accounting > Import > User-defined dimension > Add User-defined dimension.
  2. Enter anything for the Integration Name as long as it's not a real UDD in our test Sage Intacct account, ex: "Testing dimension" works.
  3. Select any option for Displayed As.
  4. Click Confirm.
  5. Click the Add user-defined dimension button.
  6. RHP stays open, I'm assuming so another UDD can be added and Sage syncs in the background.
  7. Close RHP and when Sage finishes syncing, the red error under the connection is displayed, this is the error we want to update.
image

Note for self

Don't forget to add the new error to the existing help page - https://help.expensify.com/articles/new-expensify/connections/sage-intacct/Sage-Intacct-Troubleshooting.

Why Does This Happen?

This error occurs because the r Name of the user-defined dimension in Sage Intacct is not valid.

How to Fix It

To fix this please log into Sage Intacct as an administrator to find the correct name.

To find the Integration Name in Sage Intacct:

[test and populate list of steps then add to this]

strepanier03 commented 1 month ago

I am not treating this as a bug but as an internal copy update and resource update.

melvin-bot[bot] commented 1 month ago

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 4 weeks ago

@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

strepanier03 commented 4 weeks ago

Haven't been able to prioritize this yet, needs to still.

strepanier03 commented 1 week ago

No update yet.