search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

[$250] Web - Hold - Red dot is lost on held expense when approve pending amount #50823

Open IuliiaHerets opened 2 days ago

IuliiaHerets commented 2 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.48-2 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/49910 Email or phone of affected tester (no customers): gocemate+workspaceapprover223@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Log in with your Approver account
  2. As employee Go to the room with the two expenses
  3. As employee: hold one expense
  4. Verify there is a red dot on held expense on both sides
  5. As Approver: Approve just the pending amount
  6. As Approver: back to room by click to the header

Expected Result:

Red dot should remain on held report when Approver go back to room

Actual Result:

Red dot disappears from held expense when approve pending amount. It appears only when open the held report again and navigate back to room

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/42af07e2-719e-4679-a7e8-5a7c1dbea52b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846971961812039151
  • Upwork Job ID: 1846971961812039151
  • Last Price Increase: 2024-10-17
Issue OwnerCurrent Issue Owner: @ntdiary
melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 days ago

We think that this bug might be related to #wave-collect - Release 1

IuliiaHerets commented 2 days ago

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

zanyrenney commented 6 hours ago

moving to expense.

melvin-bot[bot] commented 6 hours ago

Job added to Upwork: https://www.upwork.com/jobs/~021846971961812039151

melvin-bot[bot] commented 6 hours ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)