Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[$250] Search - The shortcut CTRL + K does not work with a user as employee in a WS #52260

Open lanitochka17 opened 3 hours ago

lanitochka17 commented 3 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.59-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5191872 Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign in to the app with a new Gmail account
  2. Choose "Get paid back by my employer" from the onboarding tasks
  3. Type a Name and Last name and click the "Continue" button
  4. Go to Settings, create a new workspace and invite a new account as an employee
  5. Log in with the new employee's account in incognito mode
  6. Press the shortcut CTRL + K to open search dialog

Expected Result:

The shortcut CTRL + K to open the search dialog should open correctly

Actual Result:

Pressing the combination CTRL + K to open the search dialog does not execute, while the other shortcuts such as CTRL + J and CTRL + D work correctly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/0885fd7c-3775-4f18-b2d0-a214f3641150

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854902169710515284
  • Upwork Job ID: 1854902169710515284
  • Last Price Increase: 2024-11-08
  • Automatic offers:
    • dukenv0307 | Contributor | 104806147
Issue OwnerCurrent Issue Owner: @eVoloshchak
melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 hours ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 3 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 3 hours ago

I ran into this problem in production already cc @daledah I believe someone pointed to your PR here https://github.com/Expensify/App/pull/51547 any chance you could have a look?

melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

daledah commented 3 hours ago

@mountiny I want to confirm this: If an account is created optimistically by another user (for this issue, the account is created by search), then when logging in, this account will not have to go through onboarding steps. Is that correct?

mountiny commented 3 hours ago

@daledah I think that is valid, the onboarding would not show up for them as we know what their purpose is in the app.

However, couple older accounts of internal employees cannot use the shortcut either

melvin-bot[bot] commented 3 hours ago

Job added to Upwork: https://www.upwork.com/jobs/~021854902169710515284

melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

mountiny commented 3 hours ago

Happy to take over, looking for proposals to get this fixed soon

mountiny commented 2 hours ago

Noting that this seems to have started from https://github.com/Expensify/App/pull/51547 so @daledah and @dukenv0307 should try to fix it

mountiny commented 2 hours ago

as its still in the regression period

melvin-bot[bot] commented 2 hours ago

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

JmillsExpensify commented 2 hours ago

P.S. I think the offending PR is here: https://github.com/Expensify/App/pull/51547#issuecomment-2463196946. I commented in it last night.

JmillsExpensify commented 2 hours ago

Ah oops, that's been made clear already above, sorry!