[Search v1.2] - Approve button disappears after deleting expense in report that has comments

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0 Reproducible in staging?: Y Reproducible in production?: N, New feature If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+00809892@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Add approvals feature is enabled in Workflows
• Admin is the approver
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit two expenses to the workspace chat
  4. Go to Search > Outstanding
  5. Note that the report has Approve button
  6. Go back to expense report in Inbox
  7. Send a message in the expense report
  8. Delete one of the expenses
  9. Go to Search > Outstanding
  10. Click on the expense
  11. Note that the expense report RHP has Approve button, but it is missing Approve button in Search

Expected Result:

Approve button will appear for the expense in Outstanding tab after the other expense is deleted

Actual Result:

Approve button does not appear for the expense in Outstanding tab after the other expense is deleted Approve button disappears after deleting expense in report that has comments

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/37000f25-7099-4f83-977b-bd10b13e0093

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot[bot]]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

It's likely a backend issue; isFromOneTransactionReport should be true.

[luacmartins]

I'll take it over as part of Search

[luacmartins]

Yea, I agree that it's a backend fix. Gonna remove the blocker since it doesn't break the functionality.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.60-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52434

If no regressions arise, payment will be issued on 2024-11-20. :confetti_ball:

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.61-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52434

If no regressions arise, payment will be issued on 2024-11-21. :confetti_ball: