[HOLD for payment 2024-12-05] [$250] Workspaces page - Update the New workspace button colour, and add "Go to workspace" to the three dot overflow menu

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.64-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: #convert thread

Action Performed:

1. Create a new account on new.expensify.com
2. Select "Manage my team's expenses"
3. Complete the onboarding steps
4. Click "Settings" bottom tab > Workspaces

Expected Result:

This is a new feature

1. Change the New workspace button to our standard button colour
2. Add "Go to workspace" to the three dot overflow menu. When clicked, navigate to the workspace settings just like you tapped the whole row.

Actual Result:

The button colour is green There's no "Go to workspace" option in the overflow menu.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858960137282592665
• Upwork Job ID: 1858960137282592665
• Last Price Increase: 2024-11-19
• Automatic offers:
• gijoe0295 | Contributor | 104993249

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021858960137282592665

[melvin-bot[bot]]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-11-19 19:53:17 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Workspaces page - Update the New workspace button colour, and add "Edit workspace" to the three dot overflow menu

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?


• Remove success from the button. https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L369
• Add edit option which will navigate to workspace onSelected just like delete action. https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L161-L172

What alternative solutions did you explore? (Optional)

Result

[gijoe0295]

Edited by proposal-police: This proposal was edited at 2024-11-19 19:54:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the New workspace button colour, and add "Edit workspace" to the three dot overflow menu

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

1. Remove success prop:

https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L366-L367

3. In here, check if isAdmin || isOwner and add the edit menu item:

https://github.com/Expensify/App/blob/90e4e00508561db6f8aa18136300ec204351187e/src/pages/workspace/WorkspacesListPage.tsx#L152

threeDotsMenuItems.push({
    icon: Expensicons.Pencil,
    text: translate('workspace.common.goto'),
    onSelected: item.action,
});

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the New workspace button colour, and add "Edit workspace" to the three dot overflow menu

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

1. Remove success props

https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L369

2. Add edit menu item

https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L180

threeDotsMenuItems.push({
    icon: Expensicons.Pencil,
    text: 'Edit Workspace',
    onSelected: item.action,
});

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

📣 @pablodev07! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[jayeshmangwani]

@Krishna2323 's initial proposal was a partial solution to the issue (addressing the button color only). They edited their proposal later, but by that time, @gijoe0295 had already posted their proposal.

[jayeshmangwani]

Lets go with @gijoe0295's Proposal

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dannymcclain]

Updated the OP with a new mock based on related Slack threads. Posting the mocks here just for super ultra clarity.

[melvin-bot[bot]]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.67-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52847

If no regressions arise, payment will be issued on 2024-12-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@jayeshmangwani] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.