search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

Search - Pay button does not appear on the expense after the duplicates are sorted #53023

Open IuliiaHerets opened 1 week ago

IuliiaHerets commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.66-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+29302390@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense and pay elsewhere.
  4. Submit another expense of the same amount and merchant.
  5. Go to Search.
  6. Click Approve on the expense.
  7. Click Approve on expense RHP.
  8. Click Approve all the amount.
  9. Close the RHP.

Expected Result:

Pay button should appear on the expense because the duplicates are sorted and Pay button also appears on the expense RHP.

Actual Result:

Pay button does not appear on the expense after the duplicates are sorted. It only appears after the page is refreshed.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/c08580d8-bf96-42fa-99f0-f4658920b18f

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
cretadn22 commented 1 week ago

@luacmartins

This is a BE bug. The backend doesn't update a new value for action field

mountiny commented 6 days ago

this is specific flow and the pay button appears after refreshing or navigating away and back so I dont think this has to be a blocker for the deploy as the user is not blocked from taking the action they want to

luacmartins commented 6 days ago

I'll work on this since my PR introduced the feature

melvin-bot[bot] commented 2 days ago

@luacmartins, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!