search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

Select Currency - Symbol for XPF is the same as the name of currency #53082

Open lanitochka17 opened 4 days ago

lanitochka17 commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.66-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Open any report
  3. Tap on plus icon
  4. Tap on Pay (user)
  5. Tap on the currency name
  6. Type "XPF" in the search bar

Expected Result:

XPF symbol should be CFPF

Actual Result:

Symbol is not correctly displayed for XPF, it is the same as the name of currency

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

FitseTLT commented 4 days ago

Should be fixed in BE

ChavdaSachin commented 4 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong symbol for currency - XPF.

What is the root cause of that problem?

Wrong symbol sent from BE.

What changes do you think we should make in order to solve the problem?

Option 1. Fix the symbol from BE, and then update currency test here.... https://github.com/Expensify/App/blob/e4ac07a17c0939a7c35c231beac171bde0f99f01/tests/unit/currencyList.json#L843-L844

Option 2. Since the currency list would be mostly static and might need minimal updates - we could move currency list to frontend. Create a new file with currency list and merge data to onyx upon app initialization, or just read currency data from file itself.

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 1 day ago

@CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!