Room - No animation when returning to room settings after saving new room description

lanitochka17 commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.67.0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

precondition: user is an admin of workspace, enabled Invoice in workspace setting and sent at least one invoice

Go to https://staging.new.expensify.com/ and log in
Navigate to the invoice room or any other room
Click on the header
Select the room description
Enter new description and click on Save

Expected Result:

There is an animation when returning to the room settings

Actual Result:

There is no animation when returning to the room settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/511bd655-1e75-4a25-a429-0ef7fbdfa477

View all open jobs on GitHub

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Krishna2323 commented 4 days ago

Edited by proposal-police: This proposal was edited at 2024-11-26 18:33:46 UTC.

Proposal 

Please re-state the problem that we are trying to solve in this issue.

Room - No animation when returning to room settings after saving new room description

What is the root cause of that problem?

Onyx update and navigation is called at the same time, due to that the animation is broken.

What changes do you think we should make in order to solve the problem? 

Call Report.updateDescription(report.reportID, previousValue, newValue); or goBack() inside InteractionManager.runAfterInteractions. https://github.com/Expensify/App/blob/479edfc6a479e8bbbcdd446f1c96e5a3f2967bcf/src/pages/RoomDescriptionPage.tsx#L57-L63
We can do the same in RoomNamePage and other similar page if required.
We can also return early from submitForm if previousValue & newValue is the same.
What alternative solutions did you explore? (Optional)
We can use setNavigationActionToMicrotaskQueue. Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.navigate(backTo ?? ROUTES.REPORT_WITH_ID_DETAILS.getRoute(report.reportID)));
Result

Krishna2323 commented 4 days ago

PROPOSAL UPDATED

Added alternative

ChavdaSachin commented 4 days ago

Unable to repro... Animations are working fine for me(both chrome and safari). Is there any specific condition to repro?

Expensify / App