Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

[HOLD for payment 2025-01-28] Per diem - App shows partial offline blocking view in per diem RHP when there is no rate #54892

Closed IuliiaHerets closed 1 week ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.81-3 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers): applausetester+2390223d@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Windows 11 / Chrome App Component: Money Requests

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Submit expense > Per diem.
  4. Go offline.

Expected Result:

App should show full offline blocking view.

Actual Result:

App shows partial offline blocking view in per diem RHP when there is no rate.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6708347_1736269535563!bandicam_2025-01-08_01-01-36-236

https://github.com/user-attachments/assets/5c3127bc-0a88-4e06-8f08-267897151635

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 month ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
shubham1206agra commented 1 month ago

Will be fixed in https://github.com/Expensify/App/pull/54760/commits/394a07e612929140e676d0b5fb773e631ed80aa7.

thienlnam commented 1 month ago

Behind a beta so not a blocker

CortneyOfstad commented 1 month ago

Thanks @thienlnam!

tgolen commented 1 month ago

@shubham1206agra I'll go ahead and assign it to you since it sounds like you're working on this.

Gonals commented 4 weeks ago

Grabbing this, since I'll be reviewing it as part of the las Per Diem PR

CortneyOfstad commented 3 weeks ago

Thanks @Gonals!

melvin-bot[bot] commented 2 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.87-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-28. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 weeks ago

@shubham1206agra @CortneyOfstad @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra commented 1 week ago

@CortneyOfstad Please close this issue. No payment required here.

melvin-bot[bot] commented 1 week ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@CortneyOfstad)

CortneyOfstad commented 1 week ago

Per the comment here — this can be closed. Thanks!