Redesign search to always show search input(mobile + desktop).

[SzymczakJ]

Explanation of Change

This PR is mainly about redesigning Search Page but I also made a pretty big refactor and improved performance of Search Page mobile header animation. These are the design changes:

1. on SearchPage full screen, the SearchRouterInput is always visible, previously the SearchRouterInput was hidden when we were in "canned search" state.

2. on mobile SearchPage, we remove the button that navigates to SearchRouter

3. instead of that we put SearchRouterInput in place where SearchTypeMenuNarrow was, focusing this input is making SearchRouterList visible.

   

4. on mobile SearchPage user can still open type menu modal by pressing the button next to SearchRouterInput

These are refactor changes:

1. Refactor of SearchPageBottomTab.tsx so that it has one render for narrow screen and one render for full screen, for better readability.
2. Delete SearchTypeMenuNarrow.tsx and decuple it's logic from SearchTypeMenu.tsx, now this logic lives in SearchTypeMenuPopover.tsx with the common parts of SearchTypeMenuPopover and SearchTypeMenu put into SearchUIUtils.
3. Delete SearchSelectionModeHeader.tsx as it added unnecessary layer that was confusing.

Fixed Issues

$ https://github.com/Expensify/App/issues/52317 PROPOSAL:

Tests

1. On full screen SearchPage make sure that SearchRouterInput displays in every case.
2. Test if clicking on canned searches and saved searches works as expected.
3. Test if writing into SearchRouterInput works as expected.
4. On mobile, test scrolling SearchPage list and SearchRouterList(after focusing SearchRouterInput).
5. Test SearchRouterList, if it works as expected(if clicking on recent searches items works as expected etc.).
6. Test if advanced filters button works as expected.
7. Test if type menu button(next to SearchRouterInput) works as expected and it's possible to go to canned item or saved item.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot[bot]]

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[SzymczakJ]

Ready for review @rayane-djouah I would also like to hear opinion from design team and @luacmartins 😄

https://github.com/user-attachments/assets/60e6b5d0-41ba-4071-94fb-2eb042e340d7

[shawnborton]

I'll spin up a test build!

[luacmartins]

Kicked off the build https://github.com/Expensify/App/actions/runs/12934975324

[github-actions[bot]]

🚧 @luacmartins has triggered a test build. You can view the workflow run here.

[luacmartins]

@SzymczakJ can you merge main? We have conflicts, but more importantly we fixed some Search bugs that should be reflected on this branch too

[luacmartins]

This is looking really good though!

[luacmartins]

@rayane-djouah this would be a good PR to prioritize next too 🚀

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55078/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55078/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55078/NewExpensify.dmg	https://55078.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[rayane-djouah]

Reviewer Checklist

• [ ] I have verified the author checklist is complete (all boxes are checked off).
• [ ] I verified the correct issue is linked in the ### Fixed Issues section above
• [ ] I verified testing steps are clear and they cover the changes made in this PR
  • [ ] I verified the steps for local testing are in the Tests section
  • [ ] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [ ] I checked that screenshots or videos are included for tests on all platforms
• [ ] I included screenshots or videos for tests on all platforms
• [ ] I verified tests pass on all platforms & I tested again on:
  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop
• [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [ ] I verified proper code patterns were followed (see Reviewing the code)
  • [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [ ] I verified that comments were added to code that is not self explanatory
  • [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [ ] If a new component is created I verified that:
  • [ ] A similar component doesn't exist in the codebase
  • [ ] All props are defined accurately and each prop has a /** comment above it */
  • [ ] The file is named correctly
  • [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [ ] The only data being stored in the state is data necessary for rendering and nothing else
  • [ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [ ] All JSX used for rendering exists in the render method
  • [ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [ ] If any new file was added I verified that:
  • [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [ ] If a new CSS style is added I verified that:
  • [ ] A similar style doesn't already exist
  • [ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [ ] I verified that all the inputs inside a form are aligned with each other.
  • [ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• [ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[shawnborton]

The router feels kinda excessively tall when you open it on desktop:

Can we reduce the height? Curious if @Expensify/design agrees. Maybe like 2/3 of the overall viewport height or something? Or even a fixed amount that feels reasonable.

[shawnborton]

When I type "test" and hit enter, I don't get any results... why doesn't it actually search my query?

https://github.com/user-attachments/assets/b756570f-9ffc-4795-b236-95e5d41914c0

Also notice the really weird jump that forces a quick scrollbar on the LHN. We need to fix that too:

[shawnborton]

When I click on the Chats tab in the LHN, shouldn't the router by populated with type:chats?

Same for all of the others.

[shawnborton]

On mobile, the transition with the input and Cancel link feels slightly sluggish? Like it feels like it's just slightly after my clicking...

https://github.com/user-attachments/assets/8139cdf7-1f7b-4c94-8d58-7e46acfa1ae4

[shawnborton]

On the search input, the placeholder color is too light:

It should be our textSupporting color, which is #76847E

[Kicu]

This: https://github.com/Expensify/App/pull/55078#issuecomment-2612136303

https://github.com/Expensify/App/pull/55078#issuecomment-2612136303

Is a regression that I found a few days ago and mentioned it here: https://github.com/Expensify/App/pull/54807#issuecomment-2587516329

Forgot to follow up. We can either ask the person responsible for PR to fix, or maybe @SzymczakJ can try to fix inside this PR to speed things up. However fixing outside of PR would also make sense, as this bug was not introduced by Jakub's refactor.

[SzymczakJ]

1. Regarding @Kicu comment, I'm fine with fixing this behaviour in this PR(this seems an easy bug), so the whole SearchPage tests well

2. Regarding @shawnborton comment:

When I click on the Chats tab in the LHN, shouldn't the router by populated with type:chats?

Right now, I'm not showing the query in TextInput in case when it's one of the "canned queries", this might have been overlooked in the designs but they also point to the same bahaviour. What do you think about such aproach?

3. The sluggish transition on mobile is a big problem for us, but I'm afraid that it's caused by overall bad performance of SearchPage and Expensify's SelectionList. I will try to address this problem in next PRs, but such changes would be too big to merge the fix in this PR(I don't even know how to fix it yet 😭)

[dannymcclain]

Thanks for the detailed review Shawn! You mentioned all the things I noticed and more—I agree with all your comments.

[shawnborton]

What do you think about such aproach?

I think it makes sense to populate the canned searches with the appropriate filter. I could see not populating anything for expenses though since that's the default that we use.

[luacmartins]

Is a regression that I found a few days ago and mentioned it here: https://github.com/Expensify/App/pull/54807#issuecomment-2587516329

I believe this regression was fixed here. It's also already fixed on this branch after the latest merge with main.

[luacmartins]

I could see not populating anything for expenses though since that's the default that we use.

I'd vote that we either do it for all of the canned searches or none of them. IMO I like the current approach the most since the user interacts with the LHN and not the Search bar in those scenarios, so seeing the Search bar update feels a bit odd to me. That being said, I do find it odd that when I have Chats selected and search for something, it brings me back to Expenses

https://github.com/user-attachments/assets/cc90a772-d36c-4fe8-aba3-e5c3c23eef3c

[shawnborton]

Hmm but the LHN items are literally just shortcuts to existing search queries, and thus I think we should populate the query bar with them.

The argument for not putting it on Expenses is basically like how Gmail handles the Inbox. When you are on the Inbox in Gmail, no query is needed - it's the default set of results. However, if you go to Sent or Drafts, the query bar is updated.

[dannymcclain]

Hmm but the LHN items are literally just shortcuts to existing search queries, and thus I think we should populate the query bar with them. The argument for not putting it on Expenses is basically like how Gmail handles the Inbox. When you are on the Inbox in Gmail, no query is needed - it's the default set of results. However, if you go to Sent or Drafts, the query bar is updated.

Yeah I feel the same. I think updating the query bar reinforces and very subtly educates the user how the product works.

[luacmartins]

I'm cool with that too, not super passionate. So to align on this we'd:

1. Expenses > All doesn't show the query in the Search bar
2. Any other queries (even canned ones) would update the Search bar value

Is that right?

[luacmartins]

I'm reassigning C+ since @rayane-djouah will have limited availability next week.

[ikevin127]

@luacmartins I can finish this one today but first, is this ready for review right now (no more changes) or are we waiting on some changes based on recent discussion with design team summarized in https://github.com/Expensify/App/pull/55078#issuecomment-2613193620 ?

[luacmartins]

I think we still have the changes below:

1. Reduce the dropdown size on desktop
2. Updating the Search bar with the query when we're not at the Expenses > All filter

[ikevin127]

Cool, then @SzymczakJ please let me know when the PR is ready for review! 👍