Closed AndrewGable closed 2 weeks ago
:exclamation: Please, do not use Github auto-linking keywords such as these: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.
For more details, see the Contributing Guidelines, specifically Submit your pull request for a final review :book:.
:exclamation: Please, do not use Github auto-linking keywords such as these: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.
For more details, see the Contributing Guidelines, specifically Submit your pull request for a final review :book:.
@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
๐ Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.83-2 ๐
platform | result |
---|---|
๐ค android ๐ค | success โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ค๐ android HybridApp ๐ค๐ | cancelled ๐ช |
๐๐ iOS HybridApp ๐๐ | cancelled ๐ช |
๐ Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 ๐
platform | result |
---|---|
๐ค android ๐ค | true โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ค๐ android HybridApp ๐ค๐ | failure โ |
๐๐ iOS HybridApp ๐๐ | success โ |
๐ Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 ๐
platform | result |
---|---|
๐ค android ๐ค | true โ |
๐ฅ desktop ๐ฅ | success โ |
๐ iOS ๐ | success โ |
๐ธ web ๐ธ | success โ |
๐ค๐ android HybridApp ๐ค๐ | failure โ |
๐๐ iOS HybridApp ๐๐ | success โ |
Explanation of Change
Follow up from https://github.com/Expensify/App/pull/55090, we need to actually tell Firebase which groups to send the new release to.
Fixed Issues
$ https://github.com/Expensify/App/issues/55091
Tests
QA Steps
No QA
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop