Add view transactions cta to Expensify card and company cards page

parasharrajat commented 2 weeks ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/54800 PROPOSAL: https://github.com/Expensify/App/issues/54800#issuecomment-2571530812

Tests

Prerequisite:

Login in NewDot with an account which has a workspace.
Enable Expensify Card and Company Card from the Settings > workspaces > [Your workspace] > Workflows.
You have some assigned cards to your account from different workspaces and a assigned company card.

Expensify Card

Go to Expensify card in workspace menu on LHN.
Issue a new Expensify Card if not already.
Click on the card to view details.
Notice the View transactions button.
Click to navigate to the search page with transactions filtered to that card.

Company Card

Go to Company card in workspace menu on LHN.
Add a new Company Card if not already.
Click on the card to view details.
Notice the View transactions button.
Click to navigate to the search page with transactions filtered to that card.

Assigned Cards

Go to Settings > Wallet page.
Click on any assigned cards(Physical or virtual).
Check that it has a View Transactions button.
Click to navigate to the search page with transactions filtered to that card.
Click on any Assigned Company card.
Note that a popup opens with the view transactions button.
Click to navigate to the search page with transactions filtered to that card.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
- [x] I added steps for local testing in the Tests section
- [x] I added steps for the expected offline behavior in the Offline steps section
- [x] I added steps for Staging and/or Production testing in the QA steps section
- [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
- [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- [x] I verified that comments were added to code that is not self explanatory
- [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - [x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
- [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
- [x] A similar style doesn't already exist
- [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- [x] I verified that all the inputs inside a form are aligned with each other.
- [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/f07273dc-eb34-43e9-bab8-a87a42c3c8ab

Android: mWeb Chrome

https://github.com/user-attachments/assets/fc68557e-a843-4547-9c7b-182c749ed6bc

iOS: Native

https://github.com/user-attachments/assets/33fdd854-f785-472d-8e18-b98d255e90bd https://github.com/user-attachments/assets/cfb76545-8743-48a7-adf1-d3e83805eacb

iOS: mWeb Safari

https://github.com/user-attachments/assets/142163fc-4c72-44b4-acaa-b09b3af9bfe6

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/3bf64b12-ff9b-4dc1-a51d-a8c0abbad3d2 https://github.com/user-attachments/assets/8e0791dc-359b-4410-9782-4a03baa91988

MacOS: Desktop

https://github.com/user-attachments/assets/f039efdc-4fd0-4e5b-ab5b-e97064905c2c

melvin-bot[bot] commented 1 week ago

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf commented 1 week ago

Also please fix failing tests

mountiny commented 1 week ago

Seems like there is still some feedback to address here

shawnborton commented 1 week ago

I think the design feedback has been taken care of, so we're good there. We can also run a test build when we are close to merge to make sure it's looking good.

parasharrajat commented 1 week ago

I have made all requested changes and retested.

github-actions[bot] commented 1 week ago

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions[bot] commented 1 week ago

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55095/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
❌ FAILED ❌	https://55095.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

:eyes: View the workflow run that generated this build :eyes:

allgandalf commented 1 week ago

almost done with testing, gonna mock some onyx data for card transactions and then approve this one

shawnborton commented 1 week ago

I wonder if this should also be added to Settings > Wallet > Card details? Wallet

That would make sense to me but I don't feel strongly.

parasharrajat commented 1 week ago

One thing worth mentioning is that the card filter does not work for the cards that are owned by someone else. Even though I can see the card in my list when I the admin of a workspace but the search page does not show card filters for it.

dannymcclain commented 1 week ago

I wonder if this should also be added to Settings > Wallet > Card details? That would make sense to me but I don't feel strongly.

I don't feel strongly either but agree it would make sense. Can't think of a reason not to add it here other than it's more work.

mountiny commented 1 week ago

I wonder if this should also be added to Settings > Wallet > Card details?

Yes I think we should

parasharrajat commented 1 week ago

I don't have access to such cards and not sure how can I get one. Can I get the URL of details page so that I can directly add the button to this page?

parasharrajat commented 1 week ago

@allgandalf Can you please help get a wallet card if you know the way?

shawnborton commented 1 week ago

@robertjchen are we able to give our contributors the demo card login details they can use via OldDot to import a card into their account? That might be helpful here?

parasharrajat commented 1 week ago

@shawnborton Can you meanwhile share the url address of the page?

shawnborton commented 1 week ago

Sure, it's basically this: https://new.expensify.com/settings/wallet/card/XXXXXX

mountiny commented 1 week ago

@parasharrajat let me know when this is ready to test

allgandalf commented 6 days ago

@parasharrajat any updates on this one?

parasharrajat commented 5 days ago

Working on the popup part for company cards.

parasharrajat commented 5 days ago

@allgandalf Looks like adding a popup to the Assigned Card is not straightforward. The current implementation of PaymentMethodList does not support the assigned Cards section via props. For example, the activePaymentMethodId prop is only used for bank accounts and the cards in the payment method section. Assigned Cards are not payment methods.

There are quite some refactor needed for this.

Should I modify the existing defaultDeleteModal to contain view transactions menu as well and only show this for assigned cards. It might not be a good idea in terms of assign cards are different from Debit card and bank accounts methods which use this menu.
Add a new popover for this menu but use the existing props such as activePaymentMethodId. using these props might be misleading as assign cards are not payment methods.

What do you suggest?

Overall, it looks like that the company Cards will take a bunch of refactor to show a view transactions menu. All Expensify Cards are done.

parasharrajat commented 5 days ago

Changes done. Its ready.

shawnborton commented 5 days ago

Nice, let us know when we have updated screenshots/videos to review as well. We need them from Workspace Editor as well as Wallet > Cards

parasharrajat commented 4 days ago

@allgandalf This is ready for testing.

parasharrajat commented 4 days ago

I will share screenshots shortly. @allgandalf Can you please start testing this in the meantime?

parasharrajat commented 4 days ago

Closed mistakenly...

github-actions[bot] commented 4 days ago

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions[bot] commented 4 days ago

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55095/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55095/NewExpensify.dmg	https://55095.pr-testing.expensify.com

:eyes: View the workflow run that generated this build :eyes:

parasharrajat commented 4 days ago

Vids for web and native for wallet page. Others are attached to OP. cc: @shawnborton

https://github.com/user-attachments/assets/cfb76545-8743-48a7-adf1-d3e83805eacb

https://github.com/user-attachments/assets/8e0791dc-359b-4410-9782-4a03baa91988

mountiny commented 4 days ago

Seems to test well for me!

https://github.com/user-attachments/assets/614de450-77af-4518-8001-f8e207c62eb9

mountiny commented 4 days ago

@allgandalf how is it looking?

shawnborton commented 4 days ago

Looks great!

allgandalf commented 4 days ago

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
- [x] I verified the steps for local testing are in the Tests section
- [x] I verified the steps for Staging and/or Production testing are in the QA steps section
- [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
- [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- [x] I verified that comments were added to code that is not self explanatory
- [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
- [x] A similar component doesn't exist in the codebase
- [x] All props are defined accurately and each prop has a /** comment above it */
- [x] The file is named correctly
- [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- [x] The only data being stored in the state is data necessary for rendering and nothing else
- [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- [x] All JSX used for rendering exists in the render method
- [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
- [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
- [x] A similar style doesn't already exist
- [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- [x] I verified that all the inputs inside a form are aligned with each other.
- [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/e4e86b28-3308-4a78-be5f-3d6585f4568e

Android: mWeb Chrome

https://github.com/user-attachments/assets/a799d69f-88ef-4a11-8c54-2f666940c055

iOS: Native

https://github.com/user-attachments/assets/4782d806-21dc-424b-b5a7-fd1ae665af10

iOS: mWeb Safari

https://github.com/user-attachments/assets/9e153971-db0a-4f8c-ae0e-1f3c28a9ab3c

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/f4cb7f5f-98c8-4011-b47b-cb8475923c3a

MacOS: Desktop

https://github.com/user-attachments/assets/56832ebb-de46-4d28-8909-c58d00c6923d

mountiny commented 3 days ago

@parasharrajat can you please resolve the conflicts

parasharrajat commented 3 days ago

@mountiny Done,.

OSBotify commented 3 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 2 days ago

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Expensify / App