Deleting transactions on direct card feed settings is toggled "ON" by default

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. User added a commercial card feed
2. Navigate to card settings

Expected Result:

Deleting transactions on direct card feed settings is toggled "On" by default

when the liabilityType is not set the default should be personal

Actual Result:

Deleting transactions on direct card feed settings is toggled "Off" by default

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @fedirjh

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881820567533501084
• Upwork Job ID: 1881820567533501084
• Last Price Increase: 2025-01-21

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dukenv0307]

I'm working on WS feed project, I can take it as C+ @trjExpensify @mountiny

[mountiny]

I think this is internal

[mountiny]

Followed up in slack, the liabilityType is not set by default for commercial feeds by default, but the default value in BE I think is personal (allow deleting), but app defaults to corporate if the value is not set. So waiting to confirm and we might need to update the App

[trjExpensify]

Interesting, I've always thought the default for managed corp cards is corporate liability (can't be deleted). It's much less common to have personal liability (can be deleted) cards.

[joekaufmanexpensify]

Same. We are discussing more here.

[mountiny]

I think we will handle the update to the App default here https://github.com/Expensify/App/issues/54389

[trjExpensify]

Okay cool, so you're saying we don't need this issue as well then?

[melvin-bot[bot]]

@trjExpensify, @mountiny Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021881820567533501084

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot[bot]]

Upwork job price has been updated to $125

[mountiny]

Mixed these up, sorry, this is fixed in App in this PR https://github.com/Expensify/App/pull/55387/files

this is for the internal change

[melvin-bot[bot]]

@trjExpensify @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

What's next here, Vit?

[mountiny]

Next is to audit where we need to make these changes to change this default through the stack. Since this has been like this since ever, gonna keep this weekly.