Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.98k stars 2.98k forks source link

We aren't showing broken connection error on the feed when the connection is broken #55103

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): convert

Action Performed:

  1. User added the company card and break to revoke authorization for added card feed

    Expected Result:

    Broken connection error on the card feed page

    Actual Result:

    No error message displayed in feed page. Only thing that indicates it is not working properly is, no cards left to assign message displayed (when there is one left)

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Standalone
    • [ ] Android: HybridApp
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Standalone
    • [ ] iOS: HybridApp
    • [ ] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2025-01-10T140540 222 (1)

image - 2025-01-10T140551 919 (1)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VickyStash
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 2 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

allgandalf commented 2 weeks ago

please assign me here, callstack will implement this one most probably

VickyStash commented 1 week ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash commented 1 week ago

Updates:

VickyStash commented 1 week ago

Updates: I plan to work on this one tomorrow.

VickyStash commented 1 week ago

Updates:

TODOs:

VickyStash commented 1 week ago

Updates: I've implemented all of the TODOs mentioned above and opened the PR for review!