Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.98k stars 2.99k forks source link

[HOLD for payment 2025-01-30] Not prompting to authenticate with the bank if the credentials have expired when assigning cards from workspace member profile. #55104

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): convert

Action Performed:

Precondition: Credential status in expired condition for assigning cards

  1. Navigate to members section of a Workspace where company cards are enabled and added
  2. Select a member and click + new card
  3. Select Card and click Next

Expected Result:

Authentication page displayed to assign the card

Actual Result:

Authentication page not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/1c8d9e8e-4ad3-48ce-a739-285a0398b2ed

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 2 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

allgandalf commented 2 weeks ago

Please assign me here, this seems to be similar to the PR we worked on @waterim

mountiny commented 1 week ago

@allgandalf We are going to spread these out, the project is in a latter phase now

@waterim will take this one

kadiealexander commented 1 week ago

Thanks @mountiny I was having trouble figuring out how to repro this one.

narefyev91 commented 1 week ago

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

mountiny commented 1 week ago

@narefyev91 any updates?

narefyev91 commented 1 week ago

@narefyev91 any updates?

PR will be up in about 20 mins

Pujan92 commented 1 week ago

@mountiny Shall I review the PR as I am auto assigned or @allgandalf needs to do it?

mountiny commented 1 week ago

@Pujan92 please go ahead, but I think you cannot test this easily

Pujan92 commented 1 week ago

Ok, I will check.

melvin-bot[bot] commented 2 days ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.88-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-30. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 days ago

@mountiny @kadiealexander @narefyev91 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]