search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.98k stars 2.98k forks source link

[HOLD for payment 2025-01-22] [HOLD for payment 2025-01-21] Track expense - "Go to workspaces" button appears in upgrade modal when there is no workspace #55110

Closed IuliiaHerets closed 5 days ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.84-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers): sjdmosjomidjosdjd@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account (no workspace).
  3. Select "Track and budget expenses" during onboarding.
  4. Complete the onboarding.
  5. Go to self DM.
  6. Track an expense.
  7. Click Categorize it.

Expected Result:

The button in the upgrade modal should be "Upgrade" which allows user to directly create a new Collect workspace (production behavior).

Actual Result:

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/58bed194-a7db-43ff-8395-66afa6bc3330

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
jayeshmangwani commented 2 weeks ago

Issue is coming from PR: https://github.com/Expensify/App/pull/54771. I'm currently checking the fix for it.

cc: @DylanDylann @carlosmiceli

melvin-bot[bot] commented 1 week ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

joekaufmanexpensify commented 1 week ago

Fix is out to staging and checked off on deploy checklist, don't think this needs to be hourly anymore

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.84-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-21. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

@jayeshmangwani @joekaufmanexpensify @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.85-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

@jayeshmangwani @joekaufmanexpensify @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani commented 6 days ago

IMO, No need of a BugZero Checklist here. The issue was coming from the new feature's PR, and issue was a deploy blocker.

joekaufmanexpensify commented 5 days ago

Agreed. I also don't think any payment is required here as this was fixing a regression from a PR you worked on, so we should be all set here. Closing!