Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.98k stars 2.98k forks source link

$250 Track expense - Learn more in Upgrade modal opens not here page #55111

Open IuliiaHerets opened 2 weeks ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers): jidomjoimjoijoiji@gmail.cm Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Money Requests

Action Performed:

Go to staging.new.expensify.com
Log in with a new Gmail account.
Select "Track and budget expenses" during onboarding.
Complete the onboarding.
Go to self DM.
Track an expense.
Click Categorize it.
Click Learn more link.

Expected Result:

Learn more will open a valid page.

Actual Result:

Learn more in Upgrade modal opens not here page.

Workaround:

Unknown

Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/0a3eda97-54e8-43fe-8f2a-8aea2a0a88f5

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @DylanDylann

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

techievivek commented 1 week ago

This will be fixed here: https://github.com/Expensify/App/issues/55110, so removing the blocker label and keeping it open until we have confirmed the fix.

Beamanator commented 1 week ago

@techievivek it also seems like https://github.com/Expensify/App/pull/55117 is linked to fix this PR, is that correct or maybe no?

techievivek commented 1 week ago

That's correct, forgot to link the convo https://expensify.slack.com/archives/C01GTK53T8Q/p1736594963901249?thread_ts=1736581034.662169&cid=C01GTK53T8Q

melvin-bot[bot] commented 1 week ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.84-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/55117

If no regressions arise, payment will be issued on 2025-01-21. :confetti_ball:

melvin-bot[bot] commented 1 week ago

@techievivek @michaelkwardrop @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.85-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/55117

If no regressions arise, payment will be issued on 2025-01-22. :confetti_ball:

melvin-bot[bot] commented 1 week ago

@techievivek @michaelkwardrop @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] commented 3 days ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

michaelkwardrop commented 3 days ago

@techievivek are we good to close? ✨

mallenexpensify commented 3 days ago

@DylanDylann , it looks like you reviewed the PR, for the TestRail test case, are the below the correct steps?

Test 1

Go to staging.new.expensify.com
Log in with a new Gmail account (no workspace).
Select "Track and budget expenses" during onboarding.
Complete the onboarding.
Go to self DM.
Track an expense.
Click Categorize it.
Veify that button in the upgrade modal should be "Upgrade" which allows user to directly create a new Collect workspace.

Test 2

Go to staging.new.expensify.com
Log in with a new account.
Create a workspace.
Go to Subscription tab.
Click on the empty space under Control plan content within the box.
Verify tha empty space under Control plan content within the box should respond to click.

Test 3

Go to staging.new.expensify.com
Log in with a new account.
Create a workspace.
Go back to Settings.
Go to Subscription tab.
Verify that Control plan modal will have bottom padding.

DylanDylann commented 2 days ago

@mallenexpensify I think we only need to add test 1. Test 2, test 3 are unnecessary

Test 1

Go to staging.new.expensify.com Log in with a new Gmail account (no workspace). Select "Track and budget expenses" during onboarding. Complete the onboarding. Go to self DM. Track an expense. Click Categorize it. Veify that button in the upgrade modal should be "Upgrade" which allows user to directly create a new Collect workspace.

michaelkwardrop commented 1 day ago

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug: - [ ] 1a. Result of the original design (eg. a case wasn't considered) - [ ] 1b. Mistake during implementation - [ ] 1c. Backend bug - [ ] 1z. Other: Where bug was reported: - [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging) - [ ] 2b. Reported on staging (eg. found during regression or PR testing) - [ ] 2d. Reported on a PR - [ ] 2z. Other: Who reported the bug: - [ ] 3a. Expensify user - [ ] 3b. Expensify employee - [ ] 3c. Contributor - [ ] 3d. QA - [ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

- [ ] **[BugZero Assignee]** Create a GH issue for creating/updating the regression test once above steps have been agreed upon. Link to issue: ## Regression Test Proposal ### Precondition: - ### Test: 1. Do we agree 👍 or 👎

michaelkwardrop commented 1 day ago

@DylanDylann looks like you need to be paid for this still! Can you fill out the Checklist above?

I am not seeing this tied to any regressions caused by your contributions, right? I want to make sure I pay you the right amount! I'm new to the BugZero team so please forgive my clunkiness on these first few.

DylanDylann commented 1 day ago

@michaelkwardrop No, we should close this one

DylanDylann commented 1 day ago

For this issue only, I don't think we need any regression test

melvin-bot[bot] commented 22 hours ago

@techievivek @DylanDylann @michaelkwardrop this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!