search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.98k stars 2.98k forks source link

[HOLD for payment 2025-01-22] [HOLD for payment 2025-01-21] mWeb - Subscription - Control plan modal does not have bottom padding #55113

Closed IuliiaHerets closed 1 day ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.84-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.2 App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new account.
  3. Create a workspace.
  4. Go back to Settings.
  5. Go to Subscription tab.

Expected Result:

Control plan modal will have bottom padding.

Actual Result:

Control plan modal does not have bottom padding on mweb.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/398764b3-955e-4260-98c7-36ec8aadb68c

Bug6711591_1736572550415!Screenshot_2025-01-11_at_13 15 19

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
shubham1206agra commented 2 weeks ago

Offending PR https://github.com/Expensify/App/pull/54771

samranahm commented 2 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Control plan modal does not have bottom padding

What is the root cause of that problem?

The issue arises because both cards are styled to have the same overall height. However, the Collect card has 7 benefits, which fully utilize the available height, leaving no remaining space at the bottom. On the other hand, the Control card has 6 benefits, resulting in unused vertical space that display as additional bottom padding, creating an inconsistent appearance between the two cards.

What changes do you think we should make in order to solve the problem?

here https://github.com/Expensify/App/blob/4491e856b1692cdae4379d875713efc8429e1fc6/src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCard.tsx#L35 We can modify the condition to include multiple styles by wrapping them in an array, like this:

    index === 0 && [styles.mr3, styles.pb6]

This ensures that both styles.mr3 and styles.pb6 are applied when index === 0.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

N/A

MariaHCD commented 1 week ago

Treating this as a regression from https://github.com/Expensify/App/pull/54771

Assigning the author and C+ from that PR

melvin-bot[bot] commented 1 week ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

garrettmknight commented 1 week ago

fwiw, I don't think this needs to block any deploy

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.84-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-21. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

@jayeshmangwani / @DylanDylann @stephanieelliott @jayeshmangwani / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.85-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

@jayeshmangwani / @DylanDylann @stephanieelliott @jayeshmangwani / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani commented 6 days ago

IMO, the BugZero Checklist is not needed here. This was a deploy blocker coming from the PR https://github.com/Expensify/App/pull/54771 for a new feature, and the padding was overlooked

melvin-bot[bot] commented 3 days ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@stephanieelliott)

DylanDylann commented 1 day ago

Let's close this one

melvin-bot[bot] commented 1 day ago

@MariaHCD, @stephanieelliott, @jayeshmangwani, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

MariaHCD commented 1 day ago

Closing this out as it was a deploy blocker arising from another PR

https://github.com/Expensify/App/issues/55113#issuecomment-2600979181

Thanks, all!