Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.98k stars 2.98k forks source link

[HOLD for payment 2025-01-22] [HOLD for payment 2025-01-21] Track expense - Receipt does not load after sharing expense with accountant #55120

Closed IuliiaHerets closed 1 week ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.84-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5441811 Email or phone of affected tester (no customers): sdjomisodsmsdo@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account.
  3. Select "Track and budget expenses" during onboarding.
  4. Complete the onboarding.
  5. Go to self DM.
  6. Track an expense without receipt.
  7. Click Share it with my accountant.
  8. Click on the receipt placeholder.
  9. Add any receipt.
  10. Submit the expense to the workspace.
  11. Go to transaction thread.
  12. Click on the receipt.

Expected Result:

Receipt will load without issue.

Actual Result:

Receipt shows green placeholder in the preview. When the receipt is viewed in full screen, it shows an attachment icon.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/3a0bdcea-b428-4c19-9fac-ef0a36330b6c

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Pujan92 commented 2 weeks ago

@CyberAndrii seems to be from our PR, plz check on it.

CyberAndrii commented 2 weeks ago

PR is ready. Should I wait for @Pujan92 to be assigned here before marking it as ready for review?

Pujan92 commented 2 weeks ago

You can mark it as ready for review, I will review it.

rlinoz commented 1 week ago

Asked for a retest after CP https://expensify.slack.com/archives/C9YU7BX5M/p1736776525661989

kavimuru commented 1 week ago

Issue fixed

https://github.com/user-attachments/assets/0f6af3ed-f780-4a8f-b72b-6b0916e6b9fa

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.84-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-21. :confetti_ball:

melvin-bot[bot] commented 1 week ago

@rlinoz @OfstadC @rlinoz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.85-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-22. :confetti_ball:

melvin-bot[bot] commented 1 week ago

@rlinoz @OfstadC @rlinoz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz commented 1 week ago

BugZero Checklist:

Bug classification

Source of bug:

Where bug was reported:

Who reported the bug: