Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

feat: implement system message for the dismissed DUPLICATED_TRANSACTION #55204

Open linhvovan29546 opened 3 weeks ago

linhvovan29546 commented 3 weeks ago

Explanation of Change

Display a system message when merge transaction

Fixed Issues

$ https://github.com/Expensify/App/issues/54516 PROPOSAL: https://github.com/Expensify/App/issues/54516#issuecomment-2562158365

Tests

  1. Login as the Employee and create two duplicate expenses in workspace chat
  2. Click/Tap on any expense
  3. Click/Tap "Review Duplicates" button
  4. Click/Tap "Keep this one" on any expense
  5. Select any to keep
  6. Tap "Confirm"
  7. Verify that the system message 'resolved the duplicate' is displayed at the bottom.

Offline tests

Same test above

QA Steps

Same test above

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
linhvovan29546 commented 3 weeks ago

@getusha The PR is mostly complete, but the API does not return the report action yet. While waiting for the API, you can review the PR briefly.

Note:

I noticed that the page does not scroll down when mergeDuplicates and resolveDuplicates. Should we handle this in a separate PR or within this one? Since it also needs to be addressed in resolveDuplicates