Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

[No QA]Add new workflow to validate that HybridApp builds on every commit #55328

Closed AndrewGable closed 1 week ago

AndrewGable commented 3 weeks ago

Explanation of Change

This adds a test that verifies that the PR changes build on HybridApp using the Mobile-Expensify main branch. This test will only run when we think there are changes against files that have the possibility to break the HybridApp build (mainly native and/or dependency changes)

Fixed Issues

$ https://github.com/Expensify/App/issues/54323

Tests

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
AndrewGable commented 2 weeks ago

All green! Some last touches required to figure out caching and which files to run this on, then it will be ready for review.

melvin-bot[bot] commented 2 weeks ago

@shubham1206agra @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable commented 2 weeks ago

Also I don't see this action being run anywhere, is it automatic or just not triggered yet? -- I would like to understand.

It will only run when these conditions are met, so since there are no changes to these files it will not run. It ran earlier before I had this filter and I've attached the results in the tests section.

Julesssss commented 1 week ago

Ah thanks šŸ‘

AndrewGable commented 1 week ago

Mind reviewing @shubham1206agra ? Thanks!

shubham1206agra commented 1 week ago

Reviewer Checklist

melvin-bot[bot] commented 1 week ago

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham commented 1 week ago

oh, looks like I was too slow with my review. The slow checkouts are kind of blockerish for me (likely takes 2+ minutes and that time will only grow as time goes on). I'd be happy to address them in a follow-up.

OSBotify commented 1 week ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

AndrewGable commented 1 week ago

No worries - I can send a follow up to you

roryabraham commented 1 week ago

Created https://github.com/Expensify/App/issues/55805 if you want to take it over

github-actions[bot] commented 1 week ago

šŸš€ Deployed to staging by https://github.com/Julesssss in version: 9.0.90-0 šŸš€

platform result
šŸ¤– android šŸ¤– success āœ…
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„ success āœ…
šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„ success āœ…
github-actions[bot] commented 1 week ago

šŸš€ Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 šŸš€

platform result
šŸ¤– android šŸ¤– true āŒ
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„ failure āŒ
šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„ success āœ