Closed AndrewGable closed 1 week ago
All green! Some last touches required to figure out caching and which files to run this on, then it will be ready for review.
@shubham1206agra @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Also I don't see this action being run anywhere, is it automatic or just not triggered yet? -- I would like to understand.
It will only run when these conditions are met, so since there are no changes to these files it will not run. It ran earlier before I had this filter and I've attached the results in the tests section.
Ah thanks š
Mind reviewing @shubham1206agra ? Thanks!
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
oh, looks like I was too slow with my review. The slow checkouts are kind of blockerish for me (likely takes 2+ minutes and that time will only grow as time goes on). I'd be happy to address them in a follow-up.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
No worries - I can send a follow up to you
Created https://github.com/Expensify/App/issues/55805 if you want to take it over
š Deployed to staging by https://github.com/Julesssss in version: 9.0.90-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | success ā |
šš iOS HybridApp šš | success ā |
š Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 š
platform | result |
---|---|
š¤ android š¤ | true ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | failure ā |
šš iOS HybridApp šš | success ā |
Explanation of Change
This adds a test that verifies that the PR changes build on HybridApp using the Mobile-Expensify
main
branch. This test will only run when we think there are changes against files that have the possibility to break the HybridApp build (mainly native and/or dependency changes)Fixed Issues
$ https://github.com/Expensify/App/issues/54323
Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop