Open m-natarajan opened 2 weeks ago
Triggered auto assignment to @joekaufmanexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
π¨ Edited by proposal-police: This proposal was edited at 2025-01-24 01:06:37 UTC.
greendot flickers each time when the task checkboxes are checked
When marking task as completed, we check if the parent report (Concierge chat in this case) has any other uncompleted tasks to mark it as hasOutstandingChildTask
optimistically:
But this condition in getOutstandingChildTask
is not correct and seems like a bad merge commit:
The parent report action here should not be deleted.
The parent report action here should not be deleted. Add negate operator to ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction
above.
!ReportActionsUtils.getReportActionMessage(reportAction)?.isDeletedParentAction
Write a unit test for the case when there are many tasks within a report, if any of them has not been completed yet, the GBR should still show. The expected reason should be debug.reasonGBR.isWaitingForAssigneeToCompleteAction
. We can follow the example here.
NA
I can reproduce this. It's a very minor issue though.
Job added to Upwork: https://www.upwork.com/jobs/~021882881798258809610
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External
)
Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@jasperhuangg mind signing off on this proposal when you have a sec?
@jasperhuangg, @jayeshmangwani, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
π£ @mkzie2 π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Sorry for the delay! Proposal makes sense to me, let's move forward!
All good!
weβre waiting for @mkzie2 to raise a PR.
@jasperhuangg, @jayeshmangwani, @joekaufmanexpensify, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!
PR in review
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.89-2 Reproducible in staging?: y Reproducible in production?: y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @rayane-djouah Slack conversation (hyperlinked to channel name): expensify - bugs
Action Performed:
Expected Result:
greendot on the inbox tab shouldn't disappear and reappear
Actual Result:
greendot flickers each time when the task checkboxes are checked
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/7904d90d-9e3b-4307-a43e-6a8dac86a79f https://github.com/user-attachments/assets/00ecb6be-0fd3-4dee-a9a7-d2225efd080dView all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @jasperhuangg