Closed nyomanjyotisa closed 1 week ago
@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.90-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | success ✅ |
🍎🔄 iOS HybridApp 🍎🔄 | success ✅ |
Failing with original KI #53671 in mweb and android
https://platform.utest.com/services/links/v1/internal/56210275?.mp4 https://platform.applause.com/services/links/v1/external/5e23bcedeaa37c6eaa628d5051881069facc9cb256cd9b78dc3348b679174ced
I can't reproduce this on mWeb and Android. Could you please provide detailed test steps for clarification?
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀
platform | result |
---|---|
🤖 android 🤖 | true ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🤖🔄 android HybridApp 🤖🔄 | failure ❌ |
🍎🔄 iOS HybridApp 🍎🔄 | success ✅ |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/App/issues/53671 PROPOSAL: https://github.com/Expensify/App/issues/53671#issuecomment-2522120518
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/135e2e64-3de2-4c65-b94a-5b393545b842Android: mWeb Chrome
https://github.com/user-attachments/assets/3113f7fa-13ec-4e58-8d8a-f7b75f644d3biOS: Native
https://github.com/user-attachments/assets/98db90b7-cd58-434c-b0b1-485777e2fdfciOS: mWeb Safari
https://github.com/user-attachments/assets/f50771e1-db90-4e2e-9557-eeed1a3148d9MacOS: Chrome / Safari
https://github.com/user-attachments/assets/3a24da20-3a5b-4e3e-9541-d932c27d3673MacOS: Desktop
https://github.com/user-attachments/assets/cadde5eb-62c8-4dc7-9c63-6e2050fd4fd4