Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

User's name containing accent not shown in results if no accent in search query #55698

Closed nyomanjyotisa closed 1 week ago

nyomanjyotisa commented 2 weeks ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/53671 PROPOSAL: https://github.com/Expensify/App/issues/53671#issuecomment-2522120518

Tests

Same as QA Steps

Offline tests

Same as QA Steps

QA Steps

  1. Click on FAB > Start a chat
  2. Enter a user's name without an accent mark, e.g. Álex, Timón
  3. Verify that the username with the accent mark is displayed in the search results

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/135e2e64-3de2-4c65-b94a-5b393545b842
Android: mWeb Chrome https://github.com/user-attachments/assets/3113f7fa-13ec-4e58-8d8a-f7b75f644d3b
iOS: Native https://github.com/user-attachments/assets/98db90b7-cd58-434c-b0b1-485777e2fdfc
iOS: mWeb Safari https://github.com/user-attachments/assets/f50771e1-db90-4e2e-9557-eeed1a3148d9
MacOS: Chrome / Safari https://github.com/user-attachments/assets/3a24da20-3a5b-4e3e-9541-d932c27d3673
MacOS: Desktop https://github.com/user-attachments/assets/cadde5eb-62c8-4dc7-9c63-6e2050fd4fd4
melvin-bot[bot] commented 2 weeks ago

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 commented 1 week ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/724c7c61-f3e6-49dd-919b-49ab050cd272
Android: mWeb Chrome https://github.com/user-attachments/assets/5d57261a-6b62-4c37-b65f-f4e0b2e88907
iOS: Native https://github.com/user-attachments/assets/fde9bd4d-3882-43a1-b43e-8c35e15c9117
iOS: mWeb Safari ![accentiOSmWeb](https://github.com/user-attachments/assets/99b9a7f6-a965-43f5-af49-baa065a29a34)
MacOS: Chrome / Safari https://github.com/user-attachments/assets/ae4c2ec0-dd35-424b-bfd4-7f11fc77e35b
MacOS: Desktop https://github.com/user-attachments/assets/893b1b30-4e7a-4945-8c6a-24df4e88a097
OSBotify commented 1 week ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 1 week ago

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.90-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
kavimuru commented 1 week ago

Failing with original KI https://github.com/Expensify/App/issues/53671 in mweb and android

https://platform.utest.com/services/links/v1/internal/56210275?.mp4 https://platform.applause.com/services/links/v1/external/5e23bcedeaa37c6eaa628d5051881069facc9cb256cd9b78dc3348b679174ced

nyomanjyotisa commented 1 week ago

Failing with original KI #53671 in mweb and android

https://platform.utest.com/services/links/v1/internal/56210275?.mp4 https://platform.applause.com/services/links/v1/external/5e23bcedeaa37c6eaa628d5051881069facc9cb256cd9b78dc3348b679174ced

I can't reproduce this on mWeb and Android. Could you please provide detailed test steps for clarification?

github-actions[bot] commented 1 week ago

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅