Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.02k stars 3.01k forks source link

[No QA]Consider OD patches while calculating cache key #55713

Closed jnowakow closed 2 weeks ago

jnowakow commented 2 weeks ago

cc @AndrewGable @staszekscp

Explanation of Change

Previous setup workflow hasn't considered OD's patches when installing node-modules. Because of that there were situations where we had node-modules cached during ND build which were restored during hybrid app build resulting in crashes. Example: https://github.com/Expensify/App/issues/55659

Fixed Issues

$ PROPOSAL:

Tests

Verify that Android builds don't crash due to > Could not find method autolinkLibrariesFromCommandForPath() for arguments [../../] on extension 'reactSettings' of type com.facebook.react.ReactSettingsExtension.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 2 weeks ago

@andrewgable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
OSBotify commented 2 weeks ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 1 week ago

šŸš€ Deployed to staging by https://github.com/AndrewGable in version: 9.0.90-0 šŸš€

platform result
šŸ¤– android šŸ¤– success āœ…
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„ success āœ…
šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„ success āœ…
github-actions[bot] commented 1 week ago

šŸš€ Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 šŸš€

platform result
šŸ¤– android šŸ¤– true āŒ
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„ failure āŒ
šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„ success āœ