Closed jnowakow closed 2 weeks ago
@andrewgable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
š Deployed to staging by https://github.com/AndrewGable in version: 9.0.90-0 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | success ā |
šš iOS HybridApp šš | success ā |
š Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 š
platform | result |
---|---|
š¤ android š¤ | true ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š¤š android HybridApp š¤š | failure ā |
šš iOS HybridApp šš | success ā |
cc @AndrewGable @staszekscp
Explanation of Change
Previous setup workflow hasn't considered OD's patches when installing node-modules. Because of that there were situations where we had
node-modules
cached during ND build which were restored during hybrid app build resulting in crashes. Example: https://github.com/Expensify/App/issues/55659Fixed Issues
$ PROPOSAL:
Tests
Verify that Android builds don't crash due to
> Could not find method autolinkLibrariesFromCommandForPath() for arguments [../../] on extension 'reactSettings' of type com.facebook.react.ReactSettingsExtension.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop