Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

[$250] Expensify Card - Back button on Not so fast page closes RHP instead of returning to profile page #55720

Open vincdargento opened 3 weeks ago

vincdargento commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A https://expensify.testrail.io/index.php?/tests/view/5509731 Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Workspace Settings

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Log in as User B.
  3. Go to Account settings.
  4. Click on the account switcher.
  5. Select User A.
  6. Go to workspace settings > Members.
  7. Click on any member.
  8. Click + New card.
  9. Click RHP back button.

Expected Result:

RHP will return to the previous page which is the member profile page.

Actual Result:

RHP closes.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/5fed2a5a-60c2-44a5-8f3b-b6ccbb817a4a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021884359401351246492
  • Upwork Job ID: 1884359401351246492
  • Last Price Increase: 2025-01-28
  • Automatic offers:
    • FitseTLT | Contributor | 105969436
Issue OwnerCurrent Issue Owner: @allroundexperts
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

FitseTLT commented 3 weeks ago

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 14:11:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - Back button on Not so fast page closes RHP instead of returning to profile page

What is the root cause of that problem?

We are dismissing modal for narrow layout case here https://github.com/Expensify/App/blob/fc199faf777dc7f1710b3d5cb4ab7abf6106309c/src/components/DelegateNoAccessWrapper.tsx#L52-L55

What changes do you think we should make in order to solve the problem?

We should remove it to always goback as the default behaviour https://github.com/Expensify/App/blob/fc199faf777dc7f1710b3d5cb4ab7abf6106309c/src/components/DelegateNoAccessWrapper.tsx#L51-L57

optionally we can also goBack to the route backTo param if needed and to achieve that we can pass the backTo as a prop to DelegateNoAccessWrapper wherever needed or generally get it from the route inside DelegateNoAccessWrapper via useRoute

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 2 weeks ago

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021884359401351246492

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

allroundexperts commented 2 weeks ago

@FitseTLT's proposal looks good to me. The RCA is correct, and the proposed solution works fine.

πŸŽ€ πŸ‘€ πŸŽ€ C+ reviewed

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

mjasikowski commented 1 week ago

Proposal looks good!

melvin-bot[bot] commented 1 week ago

πŸ“£ @FitseTLT πŸŽ‰ An offer has been automatically sent to your Upwork account for the Contributor role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review πŸ§‘β€πŸ’» Keep in mind: Code of Conduct | Contributing πŸ“–