Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Wallet - No error message when adding same non-US bank account #55726

Closed vincdargento closed 2 weeks ago

vincdargento commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.89-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+erpo459@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: User Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Click Add bank account.
  4. Select any country (India) except United States.
  5. Complete the setup.
  6. After adding the bank account, click Add bank account again.
  7. Add the same bank account using the same data from Step 5.
  8. On confirmation page, mark the checkbox and click Confirm.

Expected Result:

There should be an error "Bank account can't be created, it looks like a bank account with the same information already exists in your account." when adding same bank account.

Actual Result:

There is no error when adding same bank account.

This issue does not happen when adding US bank account.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/73eed1f8-8f8b-41ab-b2a1-ca84790a247a

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 weeks ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 3 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
vincdargento commented 3 weeks ago

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

shubham1206agra commented 3 weeks ago

@MonilBhavsar This might be related to BE

dangrous commented 3 weeks ago

Are international accounts behind a beta? If so we can probably push this through and handle after deploy, since it's relatively uncommon

MonilBhavsar commented 3 weeks ago

Yes, this is under beta so not a blocker I am also not sure if this is a bug as Corpay allows creating these accounts, but I'll check

dangrous commented 2 weeks ago

Let me know what you found out @MonilBhavsar !

MonilBhavsar commented 2 weeks ago

Confirmed, this is not a bug Tested on oldDot too, and we can create an account with same account numbers.