Open lanitochka17 opened 3 weeks ago
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 21:04:07 UTC.
Sage Intacct - Preferred exporter remains the same after changing the role of admin to member
We are displaying exporter config without checking if it is an admin https://github.com/Expensify/App/blob/fc199faf777dc7f1710b3d5cb4ab7abf6106309c/src/pages/workspace/accounting/intacct/export/SageIntacctExportPage.tsx#L32 but we don't see it selected in the list when opening preferred exporter page because we only include list of admins of the workspace https://github.com/Expensify/App/blob/fc199faf777dc7f1710b3d5cb4ab7abf6106309c/src/pages/workspace/accounting/intacct/export/SageIntacctPreferredExporterPage.tsx#L31
In updateWorkspaceMembersRole we should check if it is the preferred exporter (policy?.connections?.intacct?.config.export.exporter
) and the role is being demoted from admin role then we should either
prepareOnyxDataForExportUpdate
and make the corresponding BE update on UPDATE_WORKSPACE_MEMBERS_ROLE
API updateSageIntacctExporter
to set the owner as the exporterThese problems also for the other accounting integrations so similar fix can be applied. Similarly, this changes can be applied for the case of the admin member removal from a workspace if the user was the preferred exporter.
We can create tests for updateWorkspaceMembersRole to assert it properly updates exporter when the default exporter is demoted from admin role.
If we don't want to change the exporter to the owner at least we have to avoid showing the exporter in SageIntacctExportPage if it is not an admin because it will not currently be displayed in SageIntacctPreferredExporterPage as we only include admins in the list.
Job added to Upwork: https://www.upwork.com/jobs/~021882884778254645916
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External
)
@lanitochka17, how can an external contributor test an accounting system connected to the workspace?
The preferred exporter in SageIntacctPreferredExporterPage
doesn’t update when changing the user’s role from admin to member.
The issue is that SageIntacctPreferredExporterPage is using WithPolicyProps
, which does not define the isConnectionDataFetchNeeded
variable:
This variable is defined by WithPolicyConnectionsProps
:
and is needed to trigger the connection data fetch when the role changes. Without this variable, the exporter doesn't update as expected.
In contrast, all the other pages for the account systems use WithPolicyConnectionsProps
,
, which correctly includes this variable and ensures the update is triggered when the role changes.
Change SageIntacctPreferredExporterPage
to use WithPolicyConnectionsProps
instead of WithPolicyProps
. This will ensure the component gets the isConnectionDataFetchNeeded
variable and triggers the data fetch when the role changes.
...
import type {WithPolicyConnectionsProps} from '@pages/workspace/withPolicyConnections';
...
function SageIntacctPreferredExporterPage({policy}: WithPolicyConnectionsProps) {
...
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@lschurr, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@ugogiordano If you don't have access to Sage Intacct then you won't be able to check this.
@lschurr, @dominictb Huh... This is 4 days overdue. Who can take care of this?
Just able to reproduce. Reviewing.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@lschurr, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
UpdateWorkpsaceMembersRole
and DeleteMembersFromWorkspace
API do not update the preferred exporter accordingly. This is a BE issue but we still need to work on optimistic data as well.
I need confirmation on the expected behavior.
Context: The integration's Preferred exporter should always be a workspace admin. If the current preferred exporter's role is no longer an Admin, or get removed from the workspace, what should happen?
🎀👀🎀
Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@yuwenmemon, I see you know about Sage Intacct integration in NewDot. Could you please manage this one? 🙏
Feel free to reassign it to me if you're full.
@yuwenmemon Mind giving us some ideas here https://github.com/Expensify/App/issues/55729#issuecomment-2633047640?
@yuwenmemon @lschurr @dominictb this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@yuwenmemon, @lschurr, @dominictb Whoops! This issue is 2 days overdue. Let's get this updated quick!
It should be the workspace owner, correct. This is what we do in Expensify Classic as well:
@yuwenmemon Do we want to show such message modal as well in ND? Or just fallback to the workspace owner siliently is fine?
@yuwenmemon Need 👀 on ^
@yuwenmemon, @lschurr, @dominictb Whoops! This issue is 2 days overdue. Let's get this updated quick!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.89-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): htad26+ri@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Prerequisite An account with a workspace connected to Sage Intacct
Expected Result:
The preferred exporter is changed back to the owner/admin of the workspace since only admins can be selected as preferred exporter
Actual Result:
The non-admin member is still selected as the preferred exporter even if it is not listed in the preferred exporter page. User has to manually change the exporter
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/4c80c027-390e-487f-8b82-d331b5d4169d
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @yuwenmemon