Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
4.03k stars 3.03k forks source link

Hide Split Expense from trip rooms #55735

Closed blazejkustra closed 2 weeks ago

blazejkustra commented 3 weeks ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/55665 PROPOSAL: N/A

Tests

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari ![image](https://github.com/user-attachments/assets/278cfe4e-63ae-4e4c-a384-80765dffad87)
melvin-bot[bot] commented 3 weeks ago

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra commented 3 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native Screenshot 2025-01-25 at 12 16 56 AM
Android: mWeb Chrome Screenshot 2025-01-25 at 12 03 30 AM
iOS: Native Screenshot 2025-01-25 at 12 12 39 AM
iOS: mWeb Safari Screenshot 2025-01-25 at 12 00 03 AM
MacOS: Chrome / Safari Screenshot 2025-01-24 at 11 58 19 PM
MacOS: Desktop Screenshot 2025-01-25 at 12 09 53 AM
shubham1206agra commented 3 weeks ago

@blazejkustra Can you please add a test for trip room?

blazejkustra commented 2 weeks ago

Great idea! I added one unit test :)

OSBotify commented 2 weeks ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 2 weeks ago

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.90-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅
github-actions[bot] commented 2 weeks ago

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅